From: Doug Ledford <dledford@redhat.com>
To: Colin King <colin.king@canonical.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Rajesh Borundia <rajesh.borundia@cavium.com>,
Ram Amrani <Ram.Amrani@cavium.com>,
linux-rdma@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qedr: return -EINVAL if pd is null and avoid null ptr dereference
Date: Wed, 14 Dec 2016 11:25:06 -0500 [thread overview]
Message-ID: <0fe01691-a030-de34-e984-31546c012cb2@redhat.com> (raw)
In-Reply-To: <20161018183928.8539-1-colin.king@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]
On 10/18/2016 2:39 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently, if pd is null then we hit a null pointer derference
> on accessing pd->pd_id. Instead of just printing an error message
> we should also return -EINVAL immediately.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
prev parent reply other threads:[~2016-12-14 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 18:39 [PATCH] qedr: return -EINVAL if pd is null and avoid null ptr dereference Colin King
[not found] ` <20161018183928.8539-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-10-20 7:12 ` Amrani, Ram
2016-12-14 16:25 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe01691-a030-de34-e984-31546c012cb2@redhat.com \
--to=dledford@redhat.com \
--cc=Ram.Amrani@cavium.com \
--cc=colin.king@canonical.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rajesh.borundia@cavium.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox