* Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
[not found] ` <20160823201626.13926-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
@ 2016-08-23 21:15 ` Leon Romanovsky
2016-08-23 21:24 ` Chris Wilson
2016-08-24 3:35 ` Laurence Oberman
2016-08-24 15:32 ` Doug Ledford
2 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2016-08-23 21:15 UTC (permalink / raw)
To: Chris Wilson
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Eli Cohen, Jack Morgenstein,
Or Gerlitz, Matan Barak, Doug Ledford, Sean Hefty, Hal Rosenstock
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
> Signed-off-by: Chris Wilson <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
I assume that it passed 0-day builds.
Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
2016-08-23 21:15 ` Leon Romanovsky
@ 2016-08-23 21:24 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-08-23 21:24 UTC (permalink / raw)
To: Leon Romanovsky
Cc: linux-rdma, linux-kernel, Eli Cohen, Jack Morgenstein, Or Gerlitz,
Matan Barak, Doug Ledford, Sean Hefty, Hal Rosenstock
On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> > to simplify verification of changes to io-mapping.h
> >
> > The include existed since its inception in
> >
> > commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> > Author: Eli Cohen <eli@mellanox.com>
> > Date: Sun Jul 7 17:25:49 2013 +0300
> >
> > mlx5: Add driver for Mellanox Connect-IB adapters
> >
> > which looks like a copy across from the Mellanox ethernet driver.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I assume that it passed 0-day builds.
>
> Except the commit message, which doesn't follow SubmittingPatches guide,
> it looks good.
If you mean the full commit reference rather than the short form, the
long form can be preferred if it lends significance. In this case I
wanted to highlight that it was the original commit that introduced the
include.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
[not found] ` <20160823201626.13926-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2016-08-23 21:15 ` Leon Romanovsky
@ 2016-08-24 3:35 ` Laurence Oberman
2016-08-24 15:32 ` Doug Ledford
2 siblings, 0 replies; 5+ messages in thread
From: Laurence Oberman @ 2016-08-24 3:35 UTC (permalink / raw)
To: Chris Wilson
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Eli Cohen, Jack Morgenstein,
Or Gerlitz, Matan Barak, Leon Romanovsky, Doug Ledford,
Sean Hefty, Hal Rosenstock
----- Original Message -----
> From: "Chris Wilson" <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
> To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Chris Wilson" <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>, "Eli Cohen" <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, "Jack
> Morgenstein" <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>, "Or Gerlitz" <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, "Matan Barak" <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
> "Leon Romanovsky" <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, "Doug Ledford" <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "Sean Hefty" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
> "Hal Rosenstock" <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Sent: Tuesday, August 23, 2016 4:16:26 PM
> Subject: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
>
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
> Signed-off-by: Chris Wilson <chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
> Cc: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
> Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> ---
> drivers/infiniband/hw/mlx5/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index a84bb766fc62..1b4094baa2de 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -37,7 +37,6 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/slab.h>
> -#include <linux/io-mapping.h>
> #if defined(CONFIG_X86)
> #include <asm/pat.h>
> #endif
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
I compiled and tested this with no issues on my mlx5 test bed.
Reviewed-by Laurence Oberman <loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Tested-by Laurence Oberman <loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
[not found] ` <20160823201626.13926-1-chris-Y6uKTt2uX1cEflXRtASbqLVCufUGDwFn@public.gmane.org>
2016-08-23 21:15 ` Leon Romanovsky
2016-08-24 3:35 ` Laurence Oberman
@ 2016-08-24 15:32 ` Doug Ledford
2 siblings, 0 replies; 5+ messages in thread
From: Doug Ledford @ 2016-08-24 15:32 UTC (permalink / raw)
To: Chris Wilson, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Eli Cohen, Jack Morgenstein, Or Gerlitz, Matan Barak,
Leon Romanovsky, Sean Hefty, Hal Rosenstock
[-- Attachment #1.1: Type: text/plain, Size: 722 bytes --]
On 8/23/2016 4:16 PM, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
>
> The include existed since its inception in
>
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Sun Jul 7 17:25:49 2013 +0300
>
> mlx5: Add driver for Mellanox Connect-IB adapters
>
> which looks like a copy across from the Mellanox ethernet driver.
>
Thanks, applied.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread