linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
To: Sagi Grimberg <sagi@grimberg.me>,
	Selvin Xavier <selvin.xavier@broadcom.com>,
	jgg@ziepe.ca, leon@kernel.org
Cc: linux-rdma@vger.kernel.org
Subject: RE: [PATCH v2 for-rc 3/3] IB/isert: Fix incorrect release of isert connextion
Date: Tue, 6 Jun 2023 15:57:27 +0530	[thread overview]
Message-ID: <10eac0594635f37d867111aea8df04d3@mail.gmail.com> (raw)
In-Reply-To: <cfcfc65f-a646-597f-bc5e-454f2c8a3805@grimberg.me>

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

> > The ib_isert module is releasing the isert connection both in
> > isert_wait_conn() handler as well as isert_free_conn() handler.
> > In isert_wait_conn() handler, it is expected to wait for iSCSI session
> > logout operation to complete. It should free the isert connection only
> > in isert_free_conn() handler.
> >
> > When a bunch of iSER target is cleared, this issue can lead to
> > use-after-free memory issue as isert conn is twice released
> >
> > Fixes: 0fc4ea701fcf ("Target/iser: Don't put isert_conn inside
> > disconnected handler")

> Doesn't seem quite right?

Corrected Fixes tag. Sent v3 patch.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4227 bytes --]

      reply	other threads:[~2023-06-06 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 10:56 [PATCH v2 for-rc 0/3] IB/isert Bug fixes in ib_isert Saravanan Vajravel
2023-06-02 10:56 ` [PATCH v2 for-rc 1/3] IB/isert: Fix dead lock " Saravanan Vajravel
2023-06-02 10:56 ` [PATCH v2 for-rc 2/3] IB/isert: Fix possible list corruption in CMA handler Saravanan Vajravel
2023-06-02 10:56 ` [PATCH v2 for-rc 3/3] IB/isert: Fix incorrect release of isert connextion Saravanan Vajravel
2023-06-05 22:56   ` Sagi Grimberg
2023-06-06 10:27     ` Saravanan Vajravel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10eac0594635f37d867111aea8df04d3@mail.gmail.com \
    --to=saravanan.vajravel@broadcom.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=selvin.xavier@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).