* Re: [Suspected Spam] [PATCH] RDMA/vmw_pvrdma: Disable device before releasing PCI region
[not found] <20200203183604.10801-1-yuval.shaia.ml@gmail.com>
@ 2020-02-03 18:47 ` Adit Ranadive
0 siblings, 0 replies; only message in thread
From: Adit Ranadive @ 2020-02-03 18:47 UTC (permalink / raw)
To: "Yuval Shaia yuval.shaia.ml"@gmail.com, Pv-drivers,
dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org
Cc: Yuval Shaia
On 2/3/20 10:36 AM, "Yuval Shaia yuval.shaia.ml"@gmail.com wrote:
> From: Yuval Shaia <yuval.shaia.ml@gmail.com>
>
> From Documentation/PCI/pci.tx.txt:
> Drivers should call pci_release_region() after calling
> pci_disable_device() in order to prevent two devices colliding on the
> same address range.
>
> Signed-off-by: Yuval Shaia <yuval.shaia.ml@gmail.com>
> ---
> drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> index 780fd2dfc07e..3ef5b4b60f42 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c
> @@ -1137,8 +1137,8 @@ static void pvrdma_pci_remove(struct pci_dev *pdev)
> ib_dealloc_device(&dev->ib_dev);
>
> /* Free pci resources */
> - pci_release_regions(pdev);
> pci_disable_device(pdev);
> + pci_release_regions(pdev);
> pci_set_drvdata(pdev, NULL);
> }
>
>
Looks fine to me. Please add a Fixes tag and cc stable.
Acked-by: Adit Ranadive <aditr@vmware.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-02-03 18:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200203183604.10801-1-yuval.shaia.ml@gmail.com>
2020-02-03 18:47 ` [Suspected Spam] [PATCH] RDMA/vmw_pvrdma: Disable device before releasing PCI region Adit Ranadive
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).