From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaswinder Singh Rajput Subject: [PATCH] infiniband: fops_get is not required for core, uverbs_main.c Date: Sat, 26 Sep 2009 13:46:01 +0530 Message-ID: <1253952962.3897.2.camel@ht.satnam> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML List-Id: linux-rdma@vger.kernel.org fops_get is useless as 'uverbs_event_fops' will always be 'true'. This also fix compilation warning : CC [M] drivers/infiniband/core/uverbs_main.o drivers/infiniband/core/uverbs_main.c: In function =E2=80=98ib_uverbs_a= lloc_event_file=E2=80=99: drivers/infiniband/core/uverbs_main.c:522: warning: the address of =E2=80= =98uverbs_event_fops=E2=80=99 will always evaluate as =E2=80=98true=E2=80= =99 Signed-off-by: Jaswinder Singh Rajput Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock --- drivers/infiniband/core/uverbs_main.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband= /core/uverbs_main.c index d3fff9e..a59ddd1 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c @@ -513,13 +513,8 @@ struct file *ib_uverbs_alloc_event_file(struct ib_= uverbs_file *uverbs_file, goto err; } =20 - /* - * fops_get() can't fail here, because we're coming from a - * system call on a uverbs file, which will already have a - * module reference. - */ filp =3D alloc_file(uverbs_event_mnt, dget(uverbs_event_mnt->mnt_root= ), - FMODE_READ, fops_get(&uverbs_event_fops)); + FMODE_READ, &uverbs_event_fops); if (!filp) { ret =3D -ENFILE; goto err_fd; --=20 1.6.0.6 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html