Re: [PATCH] link-local address fix for rdma_resolve_addr

Or Gerlitz
2009-10-28T14:33:31Z

Jason Gunthorpe wrote:
> Wow, seriously? You do understand the purpose of review, right?
I think I do, maybe not to the depth you and your arguments are, but
again, repeating myself: my kind of simple argument is that your review
is way beyond the --change-- suggested by a patch but rather of a whole
logic, and you block a patch b/c you don't like the logic this patch
integrates with. To some extent such practice is excepted, but you took
it to way beyond acceptable limit. I don't accept your assertion that
the whole logic is broken and it makes sense to me to have a patch from
Dave to fix the IPv6 part of it. Next or in parallel you are welcome to
sent a patch fixing/re-writing the whole bind logic or even the whole
rdma stack or the whole kernel.

> And yes, actually, accounting for how rdma_bind() is different from bind() when doing route resolution is pretty much the main remaining problem
go and fix that

Or.