Re: [PATCH] link-local address fix for rdma_resolve_addr

Jason Gunthorpe
2009-10-27T17:14:03Z

On Tue, Oct 27, 2009 at 03:01:56PM +0200, Or Gerlitz wrote:

> Don't tell me that Dave's patches are blocked b/c you discovered the
> rdma_bind design and now you don't like it, as I wrote you, Dave sent
> patch to fix the IPv6 support, during the discussion on his patches you
> come and bring up more and more issues you consider as problems (but I
> don't) and block the patch set, I don't think this is appropriate. Let
> the patches go and send your patches to fix the problems you see. Why
> anyone touching some code piece has to fix problems you see in that piece?!

Wow, seriously? You do understand the purpose of review, right?

Documentation/development-process/7.AdvancedTopics:
Different developers will review code from different points of view.
Some are mostly concerned with coding style and whether code lines
have trailing white space. Others will focus primarily on whether the
change implemented by the patch as a whole is a good thing for the
kernel or not. Yet others will check for problematic locking,
excessive stack usage, possible security issues, duplication of code
found elsewhere, adequate documentation, adverse effects on
performance, user-space ABI changes, etc. All types of review, if
they lead to better code going into the kernel, are welcome and
worthwhile.

And yes, actually, accounting for how rdma_bind() is different from
bind() when doing route resolution is pretty much the main remaining
problem.

Jason