From: Nir Muchtar <nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Nir Muchtar <nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: [PATCH V4 2/6] IB Core: Error Handler
Date: Mon, 3 Jan 2011 17:33:50 +0200 [thread overview]
Message-ID: <1294068834-17778-3-git-send-email-nirm@voltaire.com> (raw)
In-Reply-To: <1294068834-17778-1-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Added missing error handling in ib_core init. (Wasn't intentional right?)
Signed-off-by: Nir Muchtar <nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
drivers/infiniband/core/device.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index a19effa..6e06e37 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -719,15 +719,22 @@ static int __init ib_core_init(void)
int ret;
ret = ib_sysfs_setup();
- if (ret)
+ if (ret) {
printk(KERN_WARNING "Couldn't create InfiniBand device class\n");
+ goto err;
+ }
ret = ib_cache_setup();
if (ret) {
printk(KERN_WARNING "Couldn't set up InfiniBand P_Key/GID cache\n");
- ib_sysfs_cleanup();
+ goto err_sysfs;
}
+ return 0;
+
+err_sysfs:
+ ib_sysfs_cleanup();
+err:
return ret;
}
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-03 15:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 15:33 [PATCH V4 0/6] IB Netlink Interface and RDMA CM exports Nir Muchtar
[not found] ` <1294068834-17778-1-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-03 15:33 ` [PATCH V4 1/6] IB Netlink Infrastructure Nir Muchtar
[not found] ` <1294068834-17778-2-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-12 22:54 ` Roland Dreier
[not found] ` <ada7he94tt1.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-13 14:00 ` Nir Muchtar
2011-05-09 19:35 ` Roland Dreier
[not found] ` <BANLkTi=J6ZTFCz12XkL4-ZeUsuAKODRjOw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-12 14:51 ` Nir Muchtar
[not found] ` <B166D7363A9EE34182C2C57BB1F09F1501CC02A1-FXD4EHQYOQ+layAChLZOBkEOCMrvLtNR@public.gmane.org>
2011-05-12 15:55 ` Roland Dreier
2011-01-03 15:33 ` Nir Muchtar [this message]
2011-01-03 15:33 ` [PATCH V4 3/6] IB Core: Run Netlink Nir Muchtar
[not found] ` <1294068834-17778-4-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-05-10 19:28 ` Roland Dreier
[not found] ` <BANLkTim_zvRjOuTvNdC2fGWMfYptYrVTTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-12 14:56 ` Nir Muchtar
2011-01-03 15:33 ` [PATCH V4 4/6] RDMA CM: Export State Enum Nir Muchtar
2011-01-03 15:33 ` [PATCH V4 5/6] RDMA CM: Netlink Client Nir Muchtar
[not found] ` <1294068834-17778-6-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-07 20:37 ` Jason Gunthorpe
[not found] ` <20110107203742.GH1211-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-07 22:18 ` Roland Dreier
[not found] ` <adamxnc9x33.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-11 19:10 ` Jason Gunthorpe
[not found] ` <20110111191059.GC19219-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-12 12:48 ` Or Gerlitz
2011-01-17 10:20 ` Or Gerlitz
[not found] ` <4D3417E1.9090903-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-17 21:59 ` Roland Dreier
[not found] ` <adaaaizyyx6.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-17 22:11 ` Jason Gunthorpe
[not found] ` <20110117221141.GE995-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2011-01-17 22:14 ` Roland Dreier
[not found] ` <ada4o97yy7u.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-17 22:33 ` Jason Gunthorpe
2011-02-24 14:07 ` Or Gerlitz
[not found] ` <4D666604.7000700-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-02-24 14:12 ` Or Gerlitz
[not found] ` <4D666744.6010907-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-02-27 16:49 ` Roland Dreier
[not found] ` <AANLkTik-uNbochFYz1VGLBGjyU69dp5=jG=1pkSNWsCv-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-28 7:13 ` Or Gerlitz
2011-02-28 10:49 ` Nir Muchtar
2011-01-18 7:26 ` Or Gerlitz
2011-01-03 15:33 ` [PATCH V4 6/6] RDMA CM: Save Owning PID Nir Muchtar
[not found] ` <1294068834-17778-7-git-send-email-nirm-smomgflXvOZWk0Htik3J/w@public.gmane.org>
2011-01-12 22:54 ` Roland Dreier
[not found] ` <ada39ox4ts7.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-13 13:56 ` [PATCH V5 " Nir Muchtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294068834-17778-3-git-send-email-nirm@voltaire.com \
--to=nirm-smomgflxvozwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox