public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: David Dillow <dillowda-1Heg1YXhbW8@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
Cc: mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org,
	ishai-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org,
	Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Subject: Mellanox target workaround in SRP
Date: Fri, 07 Jan 2011 17:35:17 -0500	[thread overview]
Message-ID: <1294439717.6219.54.camel@lap75545.ornl.gov> (raw)

I have question regarding workaround introduced in commit 559ce8f1 of
the mainline tree:

    IB/srp: Work around data corruption bug on Mellanox targets
    
    Data corruption has been seen with Mellanox SRP targets when FMRs
    create a memory region with I/O virtual address != 0.  Add a
    workaround that disables FMR merging for Mellanox targets (OUI 0002c9).

I don't see how this can make a difference to the target -- it sees an
address and length, and there should be no visible difference to it when
it gets an FMR versus a direct-mapped region of the same space, right?
And how is it different than getting a direct or indirect descriptor
with a similar offset?

I could see there being a bug on the initiator HCA not liking such FMR
mappings, but then it should be keyed off of the vendor of our HCA and
not the target.

I'm sure this was tested and shown to fix the problem; I'm just confused
as to what the problem really was and if this is still relevant. Can
someone please enlighten me?
-- 
Dave Dillow
National Center for Computational Science
Oak Ridge National Laboratory
(865) 241-6602 office


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2011-01-07 22:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-07 22:35 David Dillow [this message]
     [not found] ` <1294439717.6219.54.camel-FqX9LgGZnHWDB2HL1qBt2PIbXMQ5te18@public.gmane.org>
2011-01-08  4:05   ` Mellanox target workaround in SRP Roland Dreier
     [not found]     ` <adaipy09h0i.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-08 18:13       ` David Dillow
     [not found]         ` <1294510396.7914.82.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-10 18:21           ` Vu Pham
     [not found]             ` <4D2B4E13.6070903-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-10 18:49               ` [ewg] " Roland Dreier
     [not found]                 ` <adapqs48uhm.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-10 19:05                   ` David Dillow
2011-01-10 19:49                   ` Vu Pham
2011-01-10 19:02               ` David Dillow
     [not found]                 ` <1294686163.3038.12.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-10 19:58                   ` Vu Pham
     [not found]                     ` <4D2B64CA.6040609-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-17  4:50                       ` David Dillow
     [not found]                         ` <1295239821.3051.1.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2011-01-18 19:53                           ` Vu Pham
     [not found]                             ` <4D35EF9C.3050609-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2011-01-18 20:05                               ` David Dillow
2011-01-10 18:51   ` Roland Dreier
     [not found]     ` <adaipxw8ue6.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2011-01-12 13:40       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294439717.6219.54.camel@lap75545.ornl.gov \
    --to=dillowda-1heg1yxhbw8@public.gmane.org \
    --cc=ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org \
    --cc=ishai-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
    --cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox