From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [RFC 1/3] RDMA: Add netlink infrastructure Date: Fri, 13 May 2011 09:44:25 -0700 Message-ID: <1305305065.8178.9.camel@Joe-Laptop> References: <1305303525-11113-1-git-send-email-roland@kernel.org> <1305303525-11113-2-git-send-email-roland@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1305303525-11113-2-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier , Nir Muchtar Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, 2011-05-13 at 09:18 -0700, Roland Dreier wrote: > From: Roland Dreier > [Dave please do not apply even if this ends up in netdev patchwork!] Just trivia: > diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c [] > +#define pr_fmt(fmt) "%s:%s: " fmt, KBUILD_MODNAME, __func__ Using #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__ generally produces smaller overall object size, especially at 64 bit. For instance, here's the size of netlink.o at 32 bit: $ size drivers/infiniband/core/netlink.o.* text data bss dec hex filename 2663 153 736 3552 de0 drivers/infiniband/core/netlink.o.old 2640 153 736 3529 dc9 drivers/infiniband/core/netlink.o.new Also, I rarely find __func__ useful in message output. It may be more useful for active development/debugging. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html