Re: [PATCH-v3] ib_srpt: Initial SRP Target merge for v3.2-rc1

["Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>]

On Sun, 2011-11-06 at 18:57 +0100, Bart Van Assche wrote:
> On Wed, Nov 2, 2011 at 5:33 PM, Nicholas A. Bellinger
> <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org> wrote:
> > This v3 patch adds the kernel module ib_srpt SCSI RDMA Protocol (SRP) target
> 
> Hi Nick,
> 
> Sorry that it took so long before I noticed, but checkpatch complains
> about the code present on the for-next-merge branch. Can you have a
> look at this ?
> 
> Thanks,
> 
> Bart.
> 
> $ git diff lio/for-next-merge^..lio/for-next-merge |
> scripts/checkpatch.pl -nosignoff -ignore=LONG_LINE -
> 
> ERROR: spaces required around that ':' (ctx:VxW)
> #4023: FILE: drivers/infiniband/ulp/srpt/ib_srpt.c:3824:
> +	return snprintf(page, PAGE_SIZE, "%d\n", (sport->enabled) ? 1: 0);
>  	                                                             ^
> 
> ERROR: code indent should use tabs where possible
> #4033: FILE: drivers/infiniband/ulp/srpt/ib_srpt.c:3834:
> +        int ret;$
> 
> WARNING: please, no spaces at the start of a line
> #4033: FILE: drivers/infiniband/ulp/srpt/ib_srpt.c:3834:
> +        int ret;$
> 
> WARNING: please, no space before tabs
> #4511: FILE: drivers/infiniband/ulp/srpt/ib_srpt.h:225:
> + * ^I^I the already initiated transfers have finished.$
> 
> total: 2 errors, 2 warnings, 4690 lines checked
> 

Fixed.

Thanks for reporting!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html