Re: [PATCH] ib_srpt: Initial SRP Target merge for v3.2-rc1

["Nicholas A. Bellinger" <nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>]

On Fri, 2011-11-11 at 12:41 +0100, Bart Van Assche wrote:
> > +static void srpt_drop_tport(struct se_wwn *wwn)
> > +{
> > +       struct srpt_port *sport = container_of(wwn, struct srpt_port, port_wwn);
> > +
> > +       pr_debug("drop_tport(%s\n", config_item_name(&sport->port_wwn.wwn_group.cg_item));
> 
> A minor comment: the above statement always never prints the port name
> - it always prints the following:
> 
> ib_srpt drop_tport((null)
> 

This comes from modern target_fabric_drop_wwn() -> config_item_put() ->
config_group_put() releasing the top level fabric config_group @
port->port_wwn.wwn_group before the last config_item_put() -> struct
configfs_group_operations->drop_item() -> TFO->drop_wwn() ->
srpt_drop_tport() has been invoked.

The informational config_item_name() also appears in a handful of other
fabric TFO->drop_wwn() code, which is really left-over usage from pre v4
target_core_fabric_configfs.c days when struct config_group was setup
and released directly by the fabrics.

Anyways, I'll go ahead and drop this legacy usage of config_item_name()
tree-wide.  Thanks for pointing this out.

--nab






--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html