From: Ben Hutchings <ben@decadent.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Steve Wise <swise@chelsio.com>,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address
Date: Wed, 21 Dec 2011 02:47:30 +0000 [thread overview]
Message-ID: <1324435650.2844.182.camel@deadeye> (raw)
In-Reply-To: <1324434950.14214.3.camel@joe2Laptop>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Tue, 2011-12-20 at 18:35 -0800, Joe Perches wrote:
> On Wed, 2011-12-21 at 01:32 +0000, Ben Hutchings wrote:
> > Physical addresses may be wider than virtual addresses (e.g. on i386
> > with PAE) and must not be formatted with %p.
> []
> > The resource could alternately be formatted with %Pr.
> > diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> []
> > @@ -318,10 +318,10 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)
> > rdev->lldi.vr->qp.size,
> > rdev->lldi.vr->cq.start,
> > rdev->lldi.vr->cq.size);
> > - PDBG("udb len 0x%x udb base %p db_reg %p gts_reg %p qpshift %lu "
> > + PDBG("udb len 0x%x udb base %llx db_reg %p gts_reg %p qpshift %lu "
> > "qpmask 0x%x cqshift %lu cqmask 0x%x\n",
> > (unsigned)pci_resource_len(rdev->lldi.pdev, 2),
> > - (void *)pci_resource_start(rdev->lldi.pdev, 2),
> > + (u64)pci_resource_start(rdev->lldi.pdev, 2),
>
> Probably should be unsigned long long
unsigned long long is so long long long to type. And u64 is now defined
as unsigned long long on all architectures, partly because of that.
Ben.
--
Ben Hutchings
Humans are not rational beings; they are rationalising beings.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-12-21 2:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 1:29 [PATCH 0/8] Fix virtual and physical address types Ben Hutchings
2011-12-21 1:32 ` [PATCH 1/8] IB/cxgb4: Fix formatting of physical address Ben Hutchings
2011-12-21 2:35 ` Joe Perches
2011-12-21 2:47 ` Ben Hutchings [this message]
2011-12-22 19:52 ` Valdis.Kletnieks-PjAqaU27lzQ
2011-12-21 14:12 ` Steve Wise
-- strict thread matches above, loose matches on Subject: below --
2013-10-27 21:47 [PATCH 0/8] Fix minor address type errors Ben Hutchings
[not found] ` <1382910437.2994.43.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2013-10-27 21:50 ` [PATCH 1/8] IB/cxgb4: Fix formatting of physical address Ben Hutchings
[not found] ` <1382910645.2994.45.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2013-10-27 21:58 ` Joe Perches
2013-10-27 22:02 ` Ben Hutchings
[not found] ` <1382911333.2994.55.camel-nDn/Rdv9kqW9Jme8/bJn5UCKIB8iOfG2tUK59QYPAWc@public.gmane.org>
2013-10-27 22:14 ` Joe Perches
2013-10-27 22:26 ` Ben Hutchings
2013-10-27 22:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324435650.2844.182.camel@deadeye \
--to=ben@decadent.org.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox