linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH libibverbs] memory: commented unused verify() function
@ 2012-07-11 15:10 Yann Droneaud
       [not found] ` <1342019410-10004-1-git-send-email-ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Yann Droneaud @ 2012-07-11 15:10 UTC (permalink / raw)
  To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Yann Droneaud

Signed-off-by: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
---
 src/memory.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/memory.c b/src/memory.c
index faa43f3..ea9e712 100644
--- a/src/memory.c
+++ b/src/memory.c
@@ -268,6 +268,7 @@ static void __mm_rotate_left(struct ibv_mem_node *node)
 	node->parent = tmp;
 }
 
+#if 0
 static int verify(struct ibv_mem_node *node)
 {
 	int hl, hr;
@@ -293,6 +294,7 @@ static int verify(struct ibv_mem_node *node)
 
 	return hl + 1;
 }
+#endif
 
 static void __mm_add_rebalance(struct ibv_mem_node *node)
 {
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH libibverbs] memory: commented unused verify() function
       [not found] ` <1342019410-10004-1-git-send-email-ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
@ 2012-07-11 15:58   ` Or Gerlitz
       [not found]     ` <4FFDA2A9.1060500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Or Gerlitz @ 2012-07-11 15:58 UTC (permalink / raw)
  To: Yann Droneaud; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

any reason not to remove it all together?

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH libibverbs] memory: commented unused verify() function
       [not found]     ` <4FFDA2A9.1060500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
@ 2012-07-11 16:26       ` Yann Droneaud
  0 siblings, 0 replies; 3+ messages in thread
From: Yann Droneaud @ 2012-07-11 16:26 UTC (permalink / raw)
  To: Or Gerlitz; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

Hi,

Le mercredi 11 juillet 2012 à 18:58 +0300, Or Gerlitz a écrit :
> any reason not to remove it all together?
> 

It might be use for debug purpose.
Perhaps someone will add such code back after seeing my patch.

If no one step up for this, the red-black tree verification function
could be removed.

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-11 16:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-11 15:10 [PATCH libibverbs] memory: commented unused verify() function Yann Droneaud
     [not found] ` <1342019410-10004-1-git-send-email-ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2012-07-11 15:58   ` Or Gerlitz
     [not found]     ` <4FFDA2A9.1060500-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-07-11 16:26       ` Yann Droneaud

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).