From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: target-devel <target-devel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Roland Dreier <roland@kernel.org>,
Alexander Nezhinsky <alexandern@mellanox.com>
Subject: Re: [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver
Date: Thu, 04 Apr 2013 14:59:44 -0700 [thread overview]
Message-ID: <1365112784.11833.60.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <515D45F6.9040903@mellanox.com>
On Thu, 2013-04-04 at 12:20 +0300, Or Gerlitz wrote:
> On 04/04/2013 10:24, Nicholas A. Bellinger wrote:
> > +
> > +void isert_cq_tx_callback(struct ib_cq *, void *);
> > +void isert_cq_rx_callback(struct ib_cq *, void *);
> > +void isert_free_rx_descriptors(struct isert_conn *);
> any reason not to have these as static functions (same for isert_cq_rx_work)
Nope. Looking at re-orig now to avoid the use of function prototypes
here, and marking everything as static..
--nab
next prev parent reply other threads:[~2013-04-04 21:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 7:24 [RFC-v3 0/9] Add support for iSCSI Extensions for RDMA (ISER) target mode Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 1/9] target: Add export of target_get_sess_cmd symbol Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 2/9] iscsi-target: Add iscsit_transport API template Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 3/9] iscsi-target: Initial traditional TCP conversion to iscsit_transport Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 4/9] iscsi-target: Add iser-target parameter keys + setup during login Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 5/9] iscsi-target: Add per transport iscsi_cmd alloc/free Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 6/9] iscsi-target: Refactor RX PDU logic + export request PDU handling Nicholas A. Bellinger
[not found] ` <1365060256-21506-1-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-04-04 7:24 ` [RFC-v3 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 8/9] iscsi-target: Add iser network portal attribute Nicholas A. Bellinger
2013-04-04 7:24 ` [RFC-v3 9/9] iser-target: Add iSCSI Extensions for RDMA (iSER) target driver Nicholas A. Bellinger
[not found] ` <1365060256-21506-10-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2013-04-04 9:20 ` Or Gerlitz
2013-04-04 21:59 ` Nicholas A. Bellinger [this message]
2013-04-04 9:51 ` Or Gerlitz
2013-04-04 22:23 ` Nicholas A. Bellinger
2013-04-04 9:45 ` Or Gerlitz
2013-04-04 22:17 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365112784.11833.60.camel@haakon2.linux-iscsi.org \
--to=nab@linux-iscsi.org \
--cc=alexandern@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=roland@kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox