linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] infiniband: hw: fix uninitialized ‘old_qps’
@ 2013-09-13 17:38 Antonio Alecrim Jr
  0 siblings, 0 replies; only message in thread
From: Antonio Alecrim Jr @ 2013-09-13 17:38 UTC (permalink / raw)
  To: Roland Dreier, Sean Hefty, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: Antonio Alecrim Jr

Added missing old_qps initialization in order to fix the following
    warnings:
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function
‘_ocrdma_modify_qp’:
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1299:31: warning: ‘old_qps’
may be used uninitialized in this function [-Wmaybe-uninitialized]
  status = ocrdma_mbx_modify_qp(dev, qp, attr, attr_mask, old_qps);

Signed-off-by: Antonio Alecrim Jr <antonio.alecrim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 6e982bb..da6c23f 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -1289,6 +1289,7 @@ int _ocrdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 
 	qp = get_ocrdma_qp(ibqp);
 	dev = qp->dev;
+	old_qps = get_ibqp_state(qp->state);
 	if (attr_mask & IB_QP_STATE)
 		status = ocrdma_qp_state_change(qp, attr->qp_state, &old_qps);
 	/* if new and previous states are same hw doesn't need to
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-09-13 17:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 17:38 [PATCH 1/1] infiniband: hw: fix uninitialized ‘old_qps’ Antonio Alecrim Jr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).