* [PATCH] IB/netlink: remove superfluous RDMA_NL_GET_OP() masking
@ 2013-09-30 20:03 Mathias Krause
[not found] ` <1380571434-15391-1-git-send-email-minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Mathias Krause @ 2013-09-30 20:03 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Mathias Krause, Roland Dreier, Sean Hefty, Hal Rosenstock
'op' is the already RDMA_NL_GET_OP() masked 'type'. No need to mask it
again.
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
---
drivers/infiniband/core/netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
index da06abd..a1e9cba 100644
--- a/drivers/infiniband/core/netlink.c
+++ b/drivers/infiniband/core/netlink.c
@@ -148,7 +148,7 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
list_for_each_entry(client, &client_list, list) {
if (client->index == index) {
if (op < 0 || op >= client->nops ||
- !client->cb_table[RDMA_NL_GET_OP(op)].dump)
+ !client->cb_table[op].dump)
return -EINVAL;
{
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/netlink: remove superfluous RDMA_NL_GET_OP() masking
[not found] ` <1380571434-15391-1-git-send-email-minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
@ 2013-10-15 16:10 ` Mathias Krause
[not found] ` <CA+rthh87D+yLE-nTQwVG-LGar_e8sYUKievWUnmk30RH-q7=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Mathias Krause @ 2013-10-15 16:10 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Mathias Krause, Roland Dreier, Sean Hefty, Hal Rosenstock
On 30 September 2013 22:03, Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote:
> 'op' is the already RDMA_NL_GET_OP() masked 'type'. No need to mask it
> again.
>
> Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> ---
> drivers/infiniband/core/netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/core/netlink.c b/drivers/infiniband/core/netlink.c
> index da06abd..a1e9cba 100644
> --- a/drivers/infiniband/core/netlink.c
> +++ b/drivers/infiniband/core/netlink.c
> @@ -148,7 +148,7 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
> list_for_each_entry(client, &client_list, list) {
> if (client->index == index) {
> if (op < 0 || op >= client->nops ||
> - !client->cb_table[RDMA_NL_GET_OP(op)].dump)
> + !client->cb_table[op].dump)
> return -EINVAL;
>
> {
> --
> 1.7.10.4
>
Ping. Comments, anybody?
Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/netlink: remove superfluous RDMA_NL_GET_OP() masking
[not found] ` <CA+rthh87D+yLE-nTQwVG-LGar_e8sYUKievWUnmk30RH-q7=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2013-10-16 8:08 ` Yann Droneaud
2013-10-17 21:18 ` Hefty, Sean
1 sibling, 0 replies; 4+ messages in thread
From: Yann Droneaud @ 2013-10-16 8:08 UTC (permalink / raw)
To: Mathias Krause
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Roland Dreier, Sean Hefty,
Hal Rosenstock
Hi,
Le 15.10.2013 18:10, Mathias Krause a écrit :
> On 30 September 2013 22:03, Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> wrote:
>> 'op' is the already RDMA_NL_GET_OP() masked 'type'. No need to mask it
>> again.
>>
>> Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>> Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Signed-off-by: Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
>> ---
>> drivers/infiniband/core/netlink.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/core/netlink.c
>> b/drivers/infiniband/core/netlink.c
>> index da06abd..a1e9cba 100644
>> --- a/drivers/infiniband/core/netlink.c
>> +++ b/drivers/infiniband/core/netlink.c
>> @@ -148,7 +148,7 @@ static int ibnl_rcv_msg(struct sk_buff *skb,
>> struct nlmsghdr *nlh)
>> list_for_each_entry(client, &client_list, list) {
>> if (client->index == index) {
>> if (op < 0 || op >= client->nops ||
>> -
>> !client->cb_table[RDMA_NL_GET_OP(op)].dump)
>> + !client->cb_table[op].dump)
>> return -EINVAL;
>>
>> {
>> --
>> 1.7.10.4
>>
>
> Ping. Comments, anybody?
>
I confirm RDMA_NL_GET_OP() is already applied on op.
Reviewed-by: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
Regards.
--
Yann Droneaud
OPTEYA
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] IB/netlink: remove superfluous RDMA_NL_GET_OP() masking
[not found] ` <CA+rthh87D+yLE-nTQwVG-LGar_e8sYUKievWUnmk30RH-q7=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-16 8:08 ` Yann Droneaud
@ 2013-10-17 21:18 ` Hefty, Sean
1 sibling, 0 replies; 4+ messages in thread
From: Hefty, Sean @ 2013-10-17 21:18 UTC (permalink / raw)
To: Mathias Krause,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Roland Dreier, Hal Rosenstock
> > 'op' is the already RDMA_NL_GET_OP() masked 'type'. No need to mask it
> > again.
> >
> > Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Cc: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Mathias Krause <minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Acked-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > drivers/infiniband/core/netlink.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/core/netlink.c
> b/drivers/infiniband/core/netlink.c
> > index da06abd..a1e9cba 100644
> > --- a/drivers/infiniband/core/netlink.c
> > +++ b/drivers/infiniband/core/netlink.c
> > @@ -148,7 +148,7 @@ static int ibnl_rcv_msg(struct sk_buff *skb, struct
> nlmsghdr *nlh)
> > list_for_each_entry(client, &client_list, list) {
> > if (client->index == index) {
> > if (op < 0 || op >= client->nops ||
> > - !client->cb_table[RDMA_NL_GET_OP(op)].dump)
> > + !client->cb_table[op].dump)
> > return -EINVAL;
> >
> > {
> > --
> > 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-17 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 20:03 [PATCH] IB/netlink: remove superfluous RDMA_NL_GET_OP() masking Mathias Krause
[not found] ` <1380571434-15391-1-git-send-email-minipli-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2013-10-15 16:10 ` Mathias Krause
[not found] ` <CA+rthh87D+yLE-nTQwVG-LGar_e8sYUKievWUnmk30RH-q7=GA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-10-16 8:08 ` Yann Droneaud
2013-10-17 21:18 ` Hefty, Sean
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).