From: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
To: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Igor Ivanov <Igor.Ivanov-wN0M4riKYwLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH for-next V1 8/8] IB/core: extended command: move comp_mask to the extended header
Date: Tue, 05 Nov 2013 10:20:27 +0100 [thread overview]
Message-ID: <1383643227.18301.50.camel@localhost.localdomain> (raw)
In-Reply-To: <1383126771-7658-9-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Hi Matan,
Le mercredi 30 octobre 2013 à 11:52 +0200, Matan Barak a écrit :
> From: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
>
> The unused field in the extended header is a perfect candidate
> to hold the command "comp_mask" (eg. bit field used to handle
> compatibility). This was suggested by Roland Dreier in a previous
> review[1].
>
> So this patch move comp_mask from create_flow/destroy_flow commands
> to the extended command header. Then comp_mask is passed as part
> of function parameters.
>
As I wrote in a previous mail, I think this "comp_mask" should not be
handled specificaly since a "comp_mask" might be also needed for the
"provider"
So I'm now in favor of dropping this patch and adding a note in the
patch which update the framework about the usage of "comp_mask" in each
part of the command/response.
Regards.
--
Yann Droneaud
OPTEYA
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-11-05 9:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 9:52 [PATCH for-next V1 0/8] uverbs extensions fixes Matan Barak
[not found] ` <1383126771-7658-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-10-30 9:52 ` [PATCH for-next V1 1/8] IB/core: re-enable create_flow/destroy_flow uverbs Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 2/8] IB/core: clarify overflow/underflow checks on ib_create/destroy_flow Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 3/8] IB/core: Rename 'flow' structs to match other uverbs structs Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 4/8] IB/core: Makes uverbs flow structure using names more similar to verbs ones Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 5/8] IB/core: Uses a common header for uverbs flow_specs Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 6/8] IB/core: Remove ib_uverbs_flow_spec structure from userspace Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 7/8] IB/core: extended command: an improved infrastructure for uverbs commands Matan Barak
2013-10-30 9:52 ` [PATCH for-next V1 8/8] IB/core: extended command: move comp_mask to the extended header Matan Barak
[not found] ` <1383126771-7658-9-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-05 9:20 ` Yann Droneaud [this message]
2013-11-05 9:05 ` [PATCH for-next V1 0/8] uverbs extensions fixes Yann Droneaud
[not found] ` <1383642320.18301.46.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2013-11-05 13:23 ` Or Gerlitz
[not found] ` <5278F143.5070001-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-06 15:02 ` Or Gerlitz
[not found] ` <527A5A20.5050907-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2013-11-06 16:51 ` Yann Droneaud
[not found] ` <2f2cc2c0237e938586f475c2fae187cd-zgzEX58YAwA@public.gmane.org>
2013-11-06 20:41 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383643227.18301.50.camel@localhost.localdomain \
--to=ydroneaud-rly5vtjfyj3qt0dzr+alfa@public.gmane.org \
--cc=Igor.Ivanov-wN0M4riKYwLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox