From: sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
To: sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
john.fleck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 2/9] ibacm: Rename client array
Date: Sun, 23 Mar 2014 13:18:14 -0700 [thread overview]
Message-ID: <1395605901-9080-3-git-send-email-sean.hefty@intel.com> (raw)
In-Reply-To: <1395605901-9080-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
From: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Rename the client array to client_array, to make it easier
to distinguish between the array and local variables, which
are also named client.
And, hey, this found the bug in the previous patch.
Signed-off-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
src/acm.c | 28 ++++++++++++++--------------
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/src/acm.c b/src/acm.c
index c403aa8..57d34dc 100644
--- a/src/acm.c
+++ b/src/acm.c
@@ -210,7 +210,7 @@ static event_t timeout_event;
static atomic_t wait_cnt;
static SOCKET listen_socket;
-static struct acm_client client[FD_SETSIZE - 1];
+static struct acm_client client_array[FD_SETSIZE - 1];
static FILE *flog;
static lock_t log_lock;
@@ -1690,10 +1690,10 @@ static void acm_init_server(void)
int i;
for (i = 0; i < FD_SETSIZE - 1; i++) {
- lock_init(&client[i].lock);
- client[i].index = i;
- client[i].sock = INVALID_SOCKET;
- atomic_init(&client[i].refcnt);
+ lock_init(&client_array[i].lock);
+ client_array[i].index = i;
+ client_array[i].sock = INVALID_SOCKET;
+ atomic_init(&client_array[i].refcnt);
}
if (!(f = fopen("/var/run/ibacm.port", "w"))) {
@@ -1758,7 +1758,7 @@ static void acm_svr_accept(void)
}
for (i = 0; i < FD_SETSIZE - 1; i++) {
- if (!atomic_get(&client[i].refcnt))
+ if (!atomic_get(&client_array[i].refcnt))
break;
}
@@ -1768,8 +1768,8 @@ static void acm_svr_accept(void)
return;
}
- client[i].sock = s;
- atomic_set(&client[i].refcnt, 1);
+ client_array[i].sock = s;
+ atomic_set(&client_array[i].refcnt, 1);
acm_log(2, "assigned client %d\n", i);
}
@@ -2407,9 +2407,9 @@ static void acm_server(void)
FD_SET(listen_socket, &readfds);
for (i = 0; i < FD_SETSIZE - 1; i++) {
- if (client[i].sock != INVALID_SOCKET) {
- FD_SET(client[i].sock, &readfds);
- n = max(n, (int) client[i].sock);
+ if (client_array[i].sock != INVALID_SOCKET) {
+ FD_SET(client_array[i].sock, &readfds);
+ n = max(n, (int) client_array[i].sock);
}
}
@@ -2423,10 +2423,10 @@ static void acm_server(void)
acm_svr_accept();
for (i = 0; i < FD_SETSIZE - 1; i++) {
- if (client[i].sock != INVALID_SOCKET &&
- FD_ISSET(client[i].sock, &readfds)) {
+ if (client_array[i].sock != INVALID_SOCKET &&
+ FD_ISSET(client_array[i].sock, &readfds)) {
acm_log(2, "receiving from client %d\n", i);
- acm_svr_receive(&client[i]);
+ acm_svr_receive(&client_array[i]);
}
}
}
--
1.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-23 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-23 20:18 [PATCH 0/9] ibacm: Preparation for supporting different providers sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1395605901-9080-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-03-23 20:18 ` [PATCH 1/9] ibacm: Release the refcnt on the correct client sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` sean.hefty-ral2JQCrhuEAvxtiuMwx3w [this message]
2014-03-23 20:18 ` [PATCH 3/9] ibacm: Eliminate strict aliasing compiler warnings sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 4/9] ibacm: Relocate client refcnt sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 5/9] ibacm: Record index for source and destination addresses sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 6/9] ibacm: Change base endpoint name sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 7/9] ibacm: Reset endpoint state on error sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 8/9] ibacm: Store the base GID with acm_port sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-03-23 20:18 ` [PATCH 9/9] ibacm: Restructure acm_port_join sean.hefty-ral2JQCrhuEAvxtiuMwx3w
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395605901-9080-3-git-send-email-sean.hefty@intel.com \
--to=sean.hefty-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=john.fleck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox