Re: [PATCH for v3.14 0/5] Coccicheck / coccinelle catched errors on ib/hw

[Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>]

Hi Roland,

Le lundi 10 mars 2014 à 23:06 +0100, Yann Droneaud a écrit :

> Please find small but important fixes on InfiniBand/iWARP RDMA drivers for
> problems found while using coccinelle (spatch) or coccicheck.
> 

Thanks for applying those patches in your for-next branch.

You haven't made any comment on the patches but I've found you have
redacted a bit my commit messages. In particular, it seems that somes
"Cc:" were removed. I'm primary concerned about removal of Cc:
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org on one patch.

3 patches were cleared from some Cc:

- [PATCH for v3.14 1/5] IB/ehca: returns an error on ib_copy_to_udata()
failure

The patch as I proposed it:

http://marc.info/?i=a74f09417f54a40f12475b65b29094173424ff8d.1394485254.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org

The patch in your tree:

https://git.kernel.org/cgit/linux/kernel/git/roland/infiniband.git/commit/?h=for-next&id=dea2494d6901d376b8d10d297de23021fbfc3be7

Following Cc: were removed:

Cc: Hoang-Nam Nguyen <hnguyen-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Raisch <raisch-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Cc: cocci-/FJkirnvOdkvYVN+rsErww@public.gmane.org

- [PATCH for v3.14 2/5] IB/mthca: returns an error on ib_copy_to_udata()
failure

http://marc.info/?i=014a0e999228bcbefd32667b341a0fc91a8cd3c9.1394485254.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org

https://git.kernel.org/cgit/linux/kernel/git/roland/infiniband.git/commit/?h=for-next&id=13ef5c07e649b49519e7dec5896c8772a6eb5a76

Following CC: were removed

Cc: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Cc: cocci-/FJkirnvOdkvYVN+rsErww@public.gmane.org
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Here removing stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org doesn't sound right.

- [PATCH for v3.14 3/5] IB/nes: returns an error on ib_copy_from_udata()
failure instead of NULL

http://marc.info/?i=69b8f22f0d52b1c1f97b0af2b5bcecbe14cb1da2.1394485254.git.ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org

https://git.kernel.org/cgit/linux/kernel/git/roland/infiniband.git/commit/?h=for-next&id=9d194d1025f463392feafa26ff8c2d8247f71be1

Following Cc: were removed:

Cc: Faisal Latif <faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Tatyana E. Nikolova <tatyana.e.nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Cc: cocci-/FJkirnvOdkvYVN+rsErww@public.gmane.org

Could you help me to understand the reason why your selectively remove
some 'Cc:' on some patches while leaving them on other patches.

BTW, I would like to be able to help you by providing 'correct' patches
you could apply without requiring too much work from you.

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html