Re: [PATCH] RDMA/rxe: Add network namespace support

[Zhu Yanjun <yanjun.zhu@linux.dev>]

在 2026/2/26 18:05, David Ahern 写道:
> On 2/26/26 5:06 PM, yanjun.zhu wrote:
>> The patch link is: https://github.com/zhuyj/linux/tree/6.19-net-namespace
> please send the patches; I cannot give comments to a github tree.
>
> Scanning the patches, I think you have over complicated what needs to be
> done.
>
> 1. socket lookups are not free. If the rxe module is going to own the
> socket, let it own the socket. See my patch with the net_generic way of
> retrieving the socket per namespace. <several patches later> Oh, you
> also bring in net_generic, so why make this so complicated?

Thanks, I will use net_generic later.

> 2. current code creates the socket for init_net at module load time. My
> patch changes it to first rxe link create and then leaves it enabled
> until the namespace is deleted. Why? Well, any solution trying to track
> how many devices are in the namespace is overly complicated.  If an rxe
> is created once what are the odds it will be created again? This is a
> very specific type of workload. Besides, it makes the code very simple.
> I bet this is why my patch fails any test cases you have.

Yes. I will send out my commit very soon.

Thanks a lot.

Zhu Yanjun

>
-- 
Best Regards,
Yanjun.Zhu