public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 1/8] librdmacm: Remove NULL checks after calling alloca
Date: Tue,  1 Jul 2014 23:11:12 -0700	[thread overview]
Message-ID: <1404281479-6755-2-git-send-email-sean.hefty@intel.com> (raw)
In-Reply-To: <1404281479-6755-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

From: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

alloca doesn't return a NULL pointer on failure.

Signed-off-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 src/cma.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/src/cma.c b/src/cma.c
index 9a49a5b..1a88e5c 100644
--- a/src/cma.c
+++ b/src/cma.c
@@ -720,9 +720,6 @@ static int ucma_query_path(struct rdma_cm_id *id)
 
 	size = sizeof(*resp) + sizeof(struct ibv_path_data) * 6;
 	resp = alloca(size);
-	if (!resp)
-		return ERR(ENOMEM);
-
 	CMA_INIT_CMD_RESP(&cmd, sizeof cmd, QUERY, resp, size);
 	id_priv = container_of(id, struct cma_id_private, id);
 	cmd.id = id_priv->handle;
-- 
1.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-07-02  6:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02  6:11 [PATCH 0/8] librdmacm: Add support for XRC QPs sean.hefty-ral2JQCrhuEAvxtiuMwx3w
     [not found] ` <1404281479-6755-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-02  6:11   ` sean.hefty-ral2JQCrhuEAvxtiuMwx3w [this message]
2014-07-02  6:11   ` [PATCH 2/8] librdmacm: Use SRQ in rdma_create_qp sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 3/8] build: Add build support for XRC sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 4/8] rdmacm: Add functionality to allocate an XRCD sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 5/8] rdmacm: Add support for allocating XRC SRQs sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 6/8] rdmacm: Add support for XRC QPs sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 7/8] rdmacm: Update addrinfo with XRC support sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-07-02  6:11   ` [PATCH 8/8] example/rdma_xclient/server: Update XRC support in sample programs sean.hefty-ral2JQCrhuEAvxtiuMwx3w

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404281479-6755-2-git-send-email-sean.hefty@intel.com \
    --to=sean.hefty-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox