* [PATCH] rsockets: Support calling listen multiple times on same rsocket
@ 2014-09-04 18:38 sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1409855909-28819-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: sean.hefty-ral2JQCrhuEAvxtiuMwx3w @ 2014-09-04 18:38 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Sean Hefty
From: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Standard sockets allows an application to call listen() multiple
times on the same socket without error. This allows a multi-threaded
app to call listen from all threads.
rsockets will fail the second listen call. Modify the behavior to
match standard sockets.
Problem reported by: Sreedhar Kodali <srkodali-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Signed-off-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
src/rsocket.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/rsocket.c b/src/rsocket.c
index 00d9a18..4833810 100644
--- a/src/rsocket.c
+++ b/src/rsocket.c
@@ -1174,9 +1174,14 @@ int rlisten(int socket, int backlog)
rs = idm_lookup(&idm, socket);
if (!rs)
return ERR(EBADF);
- ret = rdma_listen(rs->cm_id, backlog);
- if (!ret)
- rs->state = rs_listening;
+
+ if (rs->state != rs_listening) {
+ ret = rdma_listen(rs->cm_id, backlog);
+ if (!ret)
+ rs->state = rs_listening;
+ } else {
+ ret = 0;
+ }
return ret;
}
--
1.7.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rsockets: Support calling listen multiple times on same rsocket
[not found] ` <1409855909-28819-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2014-09-05 14:14 ` Sreedhar Kodali
0 siblings, 0 replies; 2+ messages in thread
From: Sreedhar Kodali @ 2014-09-05 14:14 UTC (permalink / raw)
To: sean.hefty-ral2JQCrhuEAvxtiuMwx3w
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA
On 2014-09-05 00:08, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Standard sockets allows an application to call listen() multiple
> times on the same socket without error. This allows a multi-threaded
> app to call listen from all threads.
>
> rsockets will fail the second listen call. Modify the behavior to
> match standard sockets.
>
> Problem reported by: Sreedhar Kodali <srkodali-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>
> Signed-off-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> src/rsocket.c | 11 ++++++++---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/src/rsocket.c b/src/rsocket.c
> index 00d9a18..4833810 100644
> --- a/src/rsocket.c
> +++ b/src/rsocket.c
> @@ -1174,9 +1174,14 @@ int rlisten(int socket, int backlog)
> rs = idm_lookup(&idm, socket);
> if (!rs)
> return ERR(EBADF);
> - ret = rdma_listen(rs->cm_id, backlog);
> - if (!ret)
> - rs->state = rs_listening;
> +
> + if (rs->state != rs_listening) {
> + ret = rdma_listen(rs->cm_id, backlog);
> + if (!ret)
> + rs->state = rs_listening;
> + } else {
> + ret = 0;
> + }
> return ret;
> }
Hi Sean,
This patch is working fine.
Thank You.
- Sreedhar
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-05 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 18:38 [PATCH] rsockets: Support calling listen multiple times on same rsocket sean.hefty-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1409855909-28819-1-git-send-email-sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-05 14:14 ` Sreedhar Kodali
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox