[PATCH] rsockets: Support calling listen multiple times on same rsocket

sean.hefty-ral2JQCrhuEAvxtiuMwx3w
2014-09-04T18:38:29Z

From: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Standard sockets allows an application to call listen() multiple
times on the same socket without error. This allows a multi-threaded
app to call listen from all threads.

rsockets will fail the second listen call. Modify the behavior to
match standard sockets.

Problem reported by: Sreedhar Kodali <srkodali-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>

Signed-off-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
src/rsocket.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/rsocket.c b/src/rsocket.c
index 00d9a18..4833810 100644
--- a/src/rsocket.c
+++ b/src/rsocket.c
@@ -1174,9 +1174,14 @@ int rlisten(int socket, int backlog)
rs = idm_lookup(&idm, socket);
if (!rs)
return ERR(EBADF);
- ret = rdma_listen(rs->cm_id, backlog);
- if (!ret)
- rs->state = rs_listening;
+
+ if (rs->state != rs_listening) {
+ ret = rdma_listen(rs->cm_id, backlog);
+ if (!ret)
+ rs->state = rs_listening;
+ } else {
+ ret = 0;
+ }
return ret;
}

--
1.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html