Re: [PATCH v2 04/17] IB/core: Add umem function to read data from user-space

Yann Droneaud
2014-12-11T14:48:10Z

Hi Or,

Le jeudi 11 décembre 2014 à 15:09 +0200, Or Gerlitz a écrit :
> On Thu, Dec 11, 2014 at 2:39 PM, Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> wrote:

> > BTW, ib_copy_from_udata() is defined as an inline function. Would it be
> > better to have ib_umem_copy_from() being an inline function too ?
> > (In such case, I would remove the error message to not duplicate it
> > across all modules using the function)
>
> Yann, Lets leave your 2nd comment to be addressed as future
> cleanup/improvement. Really, these patches
> are on the list for 7-8 moths and we were asking for feedback over all
> this time, jumping now with inlining comments and such when the merge
> window is just across the door isn't appropriate.

Sure, I've no right and no power to delay or NACK anything: I'm just
lazily following the list, and my involvement in InfiniBand/RDMA
community is slowly dropping to 0, being involved in other (paid)
projects, with some spike from time to time, waiting to find time to
drain my patch queue. Unfortunately I'm not on the same schedule.

Anyway, everyone is free to provide comments at anytime.
And you're free to take them in account.

It's a fact of kernel development: sometime a patchset take many months
and multiple revision before being applied.

Regards.

--
Yann Droneaud
OPTEYA