From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Droneaud Subject: Re: [PATCH v3 06/17] IB/core: Add support for extended query device caps Date: Tue, 16 Dec 2014 21:14:48 +0100 Message-ID: <1418760888.3245.29.camel@dworkin> References: <1418310266-9584-1-git-send-email-haggaie@mellanox.com> <1418310266-9584-7-git-send-email-haggaie@mellanox.com> <1418733236.2779.26.camel@opteya.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Roland Dreier , Haggai Eran , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Liran Liss , Or Gerlitz , Sagi Grimberg , Majd Dibbiny , Jerome Glisse , Eli Cohen , Eli Cohen List-Id: linux-rdma@vger.kernel.org Hi, Le mardi 16 d=C3=A9cembre 2014 =C3=A0 22:07 +0200, Or Gerlitz a =C3=A9c= rit : > On Tue, Dec 16, 2014 at 7:41 PM, Roland Dreier wr= ote: > > On Tue, Dec 16, 2014 at 4:33 AM, Yann Droneaud wrote: > >> > >> With the suggested change here, buffer overflow won't happen, > >> but the error is silently ignored, allowing uverb to return a > >> partial result, which is likely not expected by userspace as > >> it's a bit difficult to handle it gracefully. > >> > >> So this has to be removed, and a check on userspace response > >> buffer must be added to ib_uverbs_ex_query_device() instead. > > > > I'm not sure of the specifics of the change you're suggesting here. > > Would it be OK to go forward with the patch set we have, and then f= ix > > this issue before 3.19-rc2? >=20 > Roland, >=20 > Haggai will address the change in an incremental patch against your > for-next (3.19-rc1) so the fix will be ready on time for 3.19-rc2 >=20 That's would be great. Thanks --=20 Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html