RE: [PATCH 16/20] IB/mad: Add Intel Omni-Path Architecture defines

Weiny, Ira
2015-01-19T19:57:22Z

>
> > Currently, these patches are claiming values that are controlled by an
> > established standards organization. It is the equivalent of just
> > grabbing a currently unused Ethertype value for a new protocol and
> > then claiming that whenever the IEEE allocates it for something else
> > you will make changes to resolve the conflict.
>
> It would be equivalent if OPA was Infiniband, but it is not. It is a separate
> architecture, with an entirely separate name space. Conceptually, it is similar
> to the IB GRH and the IPv6 header. They have a similar structure, but they are
> not the same. The IBTA can define a new GRH field values, such as NxtHdr,
> without consulting or getting approval from the IETF.
>
> Ira could introduce patches to define OPA management packets, but the
> general structure of those packet headers would be exactly the same as IB
> management packets. There's no need to introduce duplicate definitions into
> the code base. The existing structures can be reused. However, OPA makes
> use of different values for the fields.
>

Perhaps you can give us an example of where the current code would work without modifications if the IBTA were to define any new base or smp class version?

Would removing this patch satisfy your concerns?

commit a70a5af286b2985a0a95e9733d1e3166845a8be8
Author: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date: Tue Sep 23 20:04:49 2014 -0400

IB/mad: Add registration check for Intel Omni-Path Architecture MADs

If the registration specifies an OPA MAD class version and the device does not
support OPA MADs, fail the MAD registration.

Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Ira