Re: [PATCH FIX for-3.19] IB/ipoib: Fix failed multicast joins/sends

Or Gerlitz
2015-01-14T09:54:49Z

On 1/14/2015 8:38 AM, Doug Ledford wrote:
> The usage of IPOIB_MCAST_RUN as a flag is inconsistent. In some places
> it is used to mean "our device is administratively allowed to send
> multicast joins/leaves/packets" [...]
what? please tell which of these upstream hits (prior to any fix) has
this semantics?

# git grep -n IPOIB_MCAST_RUN drivers/infiniband/ulp/ipoib
drivers/infiniband/ulp/ipoib/ipoib.h:90: IPOIB_MCAST_RUN = 6,
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:434: if
(test_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:466: if (status &&
test_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:536: if
(test_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:550: if
(!test_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:576: if
(test_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:634:
clear_bit(IPOIB_MCAST_RUN, &priv->flags);
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:644: if
(!test_and_set_bit(IPOIB_MCAST_RUN, &priv->flags))
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:658:
clear_bit(IPOIB_MCAST_RUN, &priv->flags);
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:728: if
(!test_and_set_bit(IPOIB_MCAST_RUN, &priv->flags))