From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Amir Vadai <amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Eyal Perry <eyalpe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow
Date: Fri, 23 Jan 2015 02:48:37 -0500 [thread overview]
Message-ID: <1421999317.3352.267.camel@redhat.com> (raw)
In-Reply-To: <CAJ3xEMhX9VWobHhUmW_=kumTNL6TWG6L+RrCtT2Zd=mjg-BOew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
On Fri, 2015-01-23 at 09:07 +0200, Or Gerlitz wrote:
> >> 2. Sync between ipoib_mcast_sendonly_join() to ipoib_mcast_sendonly_join_complete
> >> using a IS_ERR_OR_NULL() test
>
> > This part is no good. You just added a kernel data corrupter or kernel
> > oopser depending on the situation.
>
> Yep, you probably have a point here, but didn't that exist prior to
> your 3.19-rc1 series too? in other words, if bug X was there before
> and you added bug Y and we fix Y that's fine and by the rules.
No. My patch set was written in response to bug A. That bug actually
had multiple sub-bugs that contributed to it. This was one of them.
Saying that it is OK because it existed before is to deny the entire
purpose of the changes.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-23 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 13:31 [PATCH V2 FIX for-3.19] IB/ipoib: Fix broken multicast flow Or Gerlitz
[not found] ` <1421933479-18214-1-git-send-email-ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-01-22 20:40 ` Doug Ledford
[not found] ` <1421959236.3352.233.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-01-23 7:07 ` Or Gerlitz
[not found] ` <CAJ3xEMhX9VWobHhUmW_=kumTNL6TWG6L+RrCtT2Zd=mjg-BOew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-23 7:48 ` Doug Ledford [this message]
2015-01-25 16:03 ` Erez Shitrit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421999317.3352.267.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=eyalpe-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox