From: Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
To: Stephen Hemminger
<stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rdma: replace deprecated ifconfig in doc
Date: Tue, 10 Mar 2015 13:47:02 +0100 [thread overview]
Message-ID: <1425991622.3991.5.camel@opteya.com> (raw)
In-Reply-To: <20150309112932.2dbbdccb@urahara>
Hi,
Le lundi 09 mars 2015 à 11:29 -0700, Stephen Hemminger a écrit :
> On Mon, 09 Mar 2015 13:06:30 +0100
> Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org> wrote:
> > Le dimanche 08 mars 2015 à 16:36 -0700, Stephen Hemminger a écrit :
> > > The ifconfig command has been deprecated for many years.
> > > To encourage new users not to continue using it and learning
> > > iproute2; the ifconfig should not be used in examples.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> > >
> > >
> > > --- a/Documentation/filesystems/nfs/nfs-rdma.txt 2014-09-28 16:27:20.393505440 -0700
> > > +++ b/Documentation/filesystems/nfs/nfs-rdma.txt 2015-03-08 16:33:21.483985810 -0700
> > > @@ -187,8 +187,10 @@ Check RDMA and NFS Setup
> > > To further test the InfiniBand software stack, use IPoIB (this
> > > assumes you have two IB hosts named host1 and host2):
> > >
> > > - host1$ ifconfig ib0 a.b.c.x
> > > - host2$ ifconfig ib0 a.b.c.y
> > > + host1$ ip link set dev ib0 up
> > > + host1$ ip address add dev ib0 a.b.c.x
> > > + host2$ ip link set dev ib0 up
> >
> > I don't think we need to "up" the device twice.
>
> You need to do it on each host.
>
Oops, missed that. Sorry.
> > > + host2$ ip address add dev ib0 a.b.c.y
> > > host1$ ping a.b.c.y
> > > host2$ ping a.b.c.x
> > >
> > > @@ -229,7 +231,8 @@ NFS/RDMA Setup
> > >
> > > $ modprobe ib_mthca
> > > $ modprobe ib_ipoib
> > > - $ ifconfig ib0 a.b.c.d
> > > + $ ip li set dev ib0 up
> >
> > s/li/link ?
>
> ip commands support shorthand.
>
Yes, sure, but here, it's looking more like a typo.
It should be consistent throughout the document.
Regards.
--
Yann Droneaud
OPTEYA
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-03-10 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 23:36 [PATCH] rdma: replace deprecated ifconfig in doc Stephen Hemminger
2015-03-09 12:06 ` Yann Droneaud
[not found] ` <1425902790.3991.3.camel-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>
2015-03-09 18:29 ` Stephen Hemminger
2015-03-10 12:47 ` Yann Droneaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425991622.3991.5.camel@opteya.com \
--to=ydroneaud-rly5vtjfyj3qt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox