public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Wang <yun.wang@profitbricks.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Tom Talpey <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Doug Ledford <dledford@redhat.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Tom Tucker <tom@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Devesh Sharma <Devesh.Sharma@Emulex.Com>,
	Liran Liss <liranl@mellanox.com>,
	Dave Goodell <dgoodell@cisco.com>
Subject: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm
Date: Tue, 28 Apr 2015 17:10:04 +0200	[thread overview]
Message-ID: <1430233823-7075-5-git-send-email-yun.wang@profitbricks.com> (raw)
In-Reply-To: <1430233823-7075-1-git-send-email-yun.wang@profitbricks.com>

Use raw management helpers to reform IB-core cm.

Cc: Hal Rosenstock <hal@dev.mellanox.co.il>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Michael Wang <yun.wang@profitbricks.com>
---
 drivers/infiniband/core/cm.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
index e28a494..add5e484 100644
--- a/drivers/infiniband/core/cm.c
+++ b/drivers/infiniband/core/cm.c
@@ -3760,11 +3760,9 @@ static void cm_add_one(struct ib_device *ib_device)
 	};
 	unsigned long flags;
 	int ret;
+	int count = 0;
 	u8 i;
 
-	if (rdma_node_get_transport(ib_device->node_type) != RDMA_TRANSPORT_IB)
-		return;
-
 	cm_dev = kzalloc(sizeof(*cm_dev) + sizeof(*port) *
 			 ib_device->phys_port_cnt, GFP_KERNEL);
 	if (!cm_dev)
@@ -3783,6 +3781,9 @@ static void cm_add_one(struct ib_device *ib_device)
 
 	set_bit(IB_MGMT_METHOD_SEND, reg_req.method_mask);
 	for (i = 1; i <= ib_device->phys_port_cnt; i++) {
+		if (!rdma_ib_or_iboe(ib_device, i))
+			continue;
+
 		port = kzalloc(sizeof *port, GFP_KERNEL);
 		if (!port)
 			goto error1;
@@ -3809,7 +3810,13 @@ static void cm_add_one(struct ib_device *ib_device)
 		ret = ib_modify_port(ib_device, i, 0, &port_modify);
 		if (ret)
 			goto error3;
+
+		count++;
 	}
+
+	if (!count)
+		goto free;
+
 	ib_set_client_data(ib_device, &cm_client, cm_dev);
 
 	write_lock_irqsave(&cm.device_lock, flags);
@@ -3825,11 +3832,15 @@ error1:
 	port_modify.set_port_cap_mask = 0;
 	port_modify.clr_port_cap_mask = IB_PORT_CM_SUP;
 	while (--i) {
+		if (!rdma_ib_or_iboe(ib_device, i))
+			continue;
+
 		port = cm_dev->port[i-1];
 		ib_modify_port(ib_device, port->port_num, 0, &port_modify);
 		ib_unregister_mad_agent(port->mad_agent);
 		cm_remove_port_fs(port);
 	}
+free:
 	device_unregister(cm_dev->device);
 	kfree(cm_dev);
 }
@@ -3853,6 +3864,9 @@ static void cm_remove_one(struct ib_device *ib_device)
 	write_unlock_irqrestore(&cm.device_lock, flags);
 
 	for (i = 1; i <= ib_device->phys_port_cnt; i++) {
+		if (!rdma_ib_or_iboe(ib_device, i))
+			continue;
+
 		port = cm_dev->port[i-1];
 		ib_modify_port(ib_device, port->port_num, 0, &port_modify);
 		ib_unregister_mad_agent(port->mad_agent);
-- 
2.1.0

  parent reply	other threads:[~2015-04-28 15:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 15:10 [PATCH v7 00/23] IB/Verbs: IB Management Helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 01/23] IB/Verbs: Implement new callback query_protocol() Michael Wang
2015-04-28 15:10 ` Michael Wang [this message]
2015-04-28 19:02   ` [PATCH v7 04/23] IB/Verbs: Reform IB-core cm Or Gerlitz
     [not found]     ` <CAJ3xEMhOg1xh5dXburjavqcy3crwWs6OoF2qEojiDxDhT-MCDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-29  7:40       ` Michael Wang
2015-04-29  8:17         ` Or Gerlitz
2015-04-29 15:48         ` Or Gerlitz
2015-04-30  7:28           ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 05/23] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-28 15:10 ` [PATCH v7 06/23] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-28 15:10 ` [PATCH v7 07/23] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-28 15:10 ` [PATCH v7 08/23] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-28 15:10 ` [PATCH v7 09/23] IB/Verbs: Reform IB-core verbs Michael Wang
     [not found] ` <1430233823-7075-1-git-send-email-yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-28 15:10   ` [PATCH v7 02/23] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-28 15:10   ` [PATCH v7 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-28 15:10   ` [PATCH v7 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-28 15:10   ` [PATCH v7 11/23] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-28 15:10   ` [PATCH v7 14/23] IB/Verbs: Reform rest " Michael Wang
2015-04-28 15:10   ` [PATCH v7 15/23] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-28 15:10   ` [PATCH v7 21/23] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-28 15:10   ` [PATCH v7 22/23] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-28 15:10   ` [PATCH v7 23/23] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-05-01  6:34   ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers ira.weiny
     [not found]     ` <20150501063428.GA30098-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-01 16:24       ` Hefty, Sean
2015-05-01 16:27         ` Weiny, Ira
2015-05-04  7:36       ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 12/23] IB/Verbs: Reform mcast related part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 13/23] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-28 15:10 ` [PATCH v7 16/23] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-28 15:10 ` [PATCH v7 17/23] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 18/23] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 19/23] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-28 15:10 ` [PATCH v7 20/23] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-29 16:28 ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers Doug Ledford
     [not found]   ` <1430324895.102408.23.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30  5:40     ` Or Gerlitz
     [not found]       ` <5541C044.7090800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  7:00         ` Doug Ledford
     [not found]           ` <1430377216.102408.47.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30  7:24             ` Or Gerlitz
     [not found]               ` <5541D8CB.8050305-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  8:11                 ` Michael Wang
     [not found]                   ` <5541E3BE.2080708-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-30  8:23                     ` Or Gerlitz
     [not found]                       ` <5541E67E.4030906-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  8:28                         ` Michael Wang
2015-04-30  7:48     ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430233823-7075-5-git-send-email-yun.wang@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=Devesh.Sharma@Emulex.Com \
    --cc=dgoodell@cisco.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox