public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Wang <yun.wang@profitbricks.com>,
	Steve Wise <swise@opengridcomputing.com>,
	Tom Talpey <tom@talpey.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Doug Ledford <dledford@redhat.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Tom Tucker <tom@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Mike Marciniszyn <infinipath@intel.com>,
	Eli Cohen <eli@mellanox.com>,
	Faisal Latif <faisal.latif@intel.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Devesh Sharma <Devesh.Sharma@Emulex.Com>,
	Liran Liss <liranl@mellanox.com>,
	Dave Goodell <dgoodell@cisco.com>
Subject: [PATCH v7 06/23] IB/Verbs: Reform IB-core multicast
Date: Tue, 28 Apr 2015 17:10:06 +0200	[thread overview]
Message-ID: <1430233823-7075-7-git-send-email-yun.wang@profitbricks.com> (raw)
In-Reply-To: <1430233823-7075-1-git-send-email-yun.wang@profitbricks.com>

Use raw management helpers to reform IB-core multicast.

Cc: Hal Rosenstock <hal@dev.mellanox.co.il>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Michael Wang <yun.wang@profitbricks.com>
---
 drivers/infiniband/core/multicast.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/infiniband/core/multicast.c b/drivers/infiniband/core/multicast.c
index fa17b55..b57ed03 100644
--- a/drivers/infiniband/core/multicast.c
+++ b/drivers/infiniband/core/multicast.c
@@ -780,8 +780,7 @@ static void mcast_event_handler(struct ib_event_handler *handler,
 	int index;
 
 	dev = container_of(handler, struct mcast_device, event_handler);
-	if (rdma_port_get_link_layer(dev->device, event->element.port_num) !=
-	    IB_LINK_LAYER_INFINIBAND)
+	if (WARN_ON(!rdma_protocol_ib(dev->device, event->element.port_num)))
 		return;
 
 	index = event->element.port_num - dev->start_port;
@@ -808,9 +807,6 @@ static void mcast_add_one(struct ib_device *device)
 	int i;
 	int count = 0;
 
-	if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB)
-		return;
-
 	dev = kmalloc(sizeof *dev + device->phys_port_cnt * sizeof *port,
 		      GFP_KERNEL);
 	if (!dev)
@@ -824,8 +820,7 @@ static void mcast_add_one(struct ib_device *device)
 	}
 
 	for (i = 0; i <= dev->end_port - dev->start_port; i++) {
-		if (rdma_port_get_link_layer(device, dev->start_port + i) !=
-		    IB_LINK_LAYER_INFINIBAND)
+		if (!rdma_protocol_ib(device, dev->start_port + i))
 			continue;
 		port = &dev->port[i];
 		port->dev = dev;
@@ -863,8 +858,7 @@ static void mcast_remove_one(struct ib_device *device)
 	flush_workqueue(mcast_wq);
 
 	for (i = 0; i <= dev->end_port - dev->start_port; i++) {
-		if (rdma_port_get_link_layer(device, dev->start_port + i) ==
-		    IB_LINK_LAYER_INFINIBAND) {
+		if (rdma_protocol_ib(device, dev->start_port + i)) {
 			port = &dev->port[i];
 			deref_port(port);
 			wait_for_completion(&port->comp);
-- 
2.1.0

  parent reply	other threads:[~2015-04-28 15:10 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 15:10 [PATCH v7 00/23] IB/Verbs: IB Management Helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 01/23] IB/Verbs: Implement new callback query_protocol() Michael Wang
2015-04-28 15:10 ` [PATCH v7 04/23] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-28 19:02   ` Or Gerlitz
     [not found]     ` <CAJ3xEMhOg1xh5dXburjavqcy3crwWs6OoF2qEojiDxDhT-MCDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-29  7:40       ` Michael Wang
2015-04-29  8:17         ` Or Gerlitz
2015-04-29 15:48         ` Or Gerlitz
2015-04-30  7:28           ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 05/23] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-28 15:10 ` Michael Wang [this message]
2015-04-28 15:10 ` [PATCH v7 07/23] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-28 15:10 ` [PATCH v7 08/23] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-28 15:10 ` [PATCH v7 09/23] IB/Verbs: Reform IB-core verbs Michael Wang
2015-04-28 15:10 ` [PATCH v7 12/23] IB/Verbs: Reform mcast related part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 13/23] IB/Verbs: Reform cma_acquire_dev() Michael Wang
     [not found] ` <1430233823-7075-1-git-send-email-yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-28 15:10   ` [PATCH v7 02/23] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-28 15:10   ` [PATCH v7 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-28 15:10   ` [PATCH v7 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-28 15:10   ` [PATCH v7 11/23] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-28 15:10   ` [PATCH v7 14/23] IB/Verbs: Reform rest " Michael Wang
2015-04-28 15:10   ` [PATCH v7 15/23] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-28 15:10   ` [PATCH v7 21/23] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-28 15:10   ` [PATCH v7 22/23] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-28 15:10   ` [PATCH v7 23/23] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-05-01  6:34   ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers ira.weiny
     [not found]     ` <20150501063428.GA30098-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-01 16:24       ` Hefty, Sean
2015-05-01 16:27         ` Weiny, Ira
2015-05-04  7:36       ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 16/23] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-28 15:10 ` [PATCH v7 17/23] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 18/23] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 19/23] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-28 15:10 ` [PATCH v7 20/23] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-29 16:28 ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers Doug Ledford
     [not found]   ` <1430324895.102408.23.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30  5:40     ` Or Gerlitz
     [not found]       ` <5541C044.7090800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  7:00         ` Doug Ledford
     [not found]           ` <1430377216.102408.47.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30  7:24             ` Or Gerlitz
     [not found]               ` <5541D8CB.8050305-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  8:11                 ` Michael Wang
     [not found]                   ` <5541E3BE.2080708-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-30  8:23                     ` Or Gerlitz
     [not found]                       ` <5541E67E.4030906-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30  8:28                         ` Michael Wang
2015-04-30  7:48     ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430233823-7075-7-git-send-email-yun.wang@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=Devesh.Sharma@Emulex.Com \
    --cc=dgoodell@cisco.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox