From: Michael Wang <yun.wang@profitbricks.com>
To: Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal@dev.mellanox.co.il>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michael Wang <yun.wang@profitbricks.com>,
Steve Wise <swise@opengridcomputing.com>,
Tom Talpey <tom@talpey.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Doug Ledford <dledford@redhat.com>,
Ira Weiny <ira.weiny@intel.com>,
Tom Tucker <tom@opengridcomputing.com>,
Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>,
Mike Marciniszyn <infinipath@intel.com>,
Eli Cohen <eli@mellanox.com>,
Faisal Latif <faisal.latif@intel.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Or Gerlitz <ogerlitz@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Devesh Sharma <Devesh.Sharma@Emulex.Com>,
Liran Liss <liranl@mellanox.com>,
Dave Goodell <dgoodell@cisco.com>
Subject: [PATCH v7 08/23] IB/Verbs: Reform IB-ulp xprtrdma
Date: Tue, 28 Apr 2015 17:10:08 +0200 [thread overview]
Message-ID: <1430233823-7075-9-git-send-email-yun.wang@profitbricks.com> (raw)
In-Reply-To: <1430233823-7075-1-git-send-email-yun.wang@profitbricks.com>
Use raw management helpers to reform IB-ulp xprtrdma.
Cc: Hal Rosenstock <hal@dev.mellanox.co.il>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Cc: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Michael Wang <yun.wang@profitbricks.com>
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +--
net/sunrpc/xprtrdma/svc_rdma_transport.c | 45 +++++++++++++-------------------
2 files changed, 20 insertions(+), 29 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index f9f13a3..2cc625d 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
@@ -117,8 +117,8 @@ static void rdma_build_arg_xdr(struct svc_rqst *rqstp,
static int rdma_read_max_sge(struct svcxprt_rdma *xprt, int sge_count)
{
- if (rdma_node_get_transport(xprt->sc_cm_id->device->node_type) ==
- RDMA_TRANSPORT_IWARP)
+ if (rdma_protocol_iwarp(xprt->sc_cm_id->device,
+ xprt->sc_cm_id->port_num))
return 1;
else
return min_t(int, sge_count, xprt->sc_max_sge);
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index f609c1c..3df8320 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -851,7 +851,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
struct ib_qp_init_attr qp_attr;
struct ib_device_attr devattr;
int uninitialized_var(dma_mr_acc);
- int need_dma_mr;
+ int need_dma_mr = 0;
int ret;
int i;
@@ -985,35 +985,26 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
/*
* Determine if a DMA MR is required and if so, what privs are required
*/
- switch (rdma_node_get_transport(newxprt->sc_cm_id->device->node_type)) {
- case RDMA_TRANSPORT_IWARP:
- newxprt->sc_dev_caps |= SVCRDMA_DEVCAP_READ_W_INV;
- if (!(newxprt->sc_dev_caps & SVCRDMA_DEVCAP_FAST_REG)) {
- need_dma_mr = 1;
- dma_mr_acc =
- (IB_ACCESS_LOCAL_WRITE |
- IB_ACCESS_REMOTE_WRITE);
- } else if (!(devattr.device_cap_flags & IB_DEVICE_LOCAL_DMA_LKEY)) {
- need_dma_mr = 1;
- dma_mr_acc = IB_ACCESS_LOCAL_WRITE;
- } else
- need_dma_mr = 0;
- break;
- case RDMA_TRANSPORT_IB:
- if (!(newxprt->sc_dev_caps & SVCRDMA_DEVCAP_FAST_REG)) {
- need_dma_mr = 1;
- dma_mr_acc = IB_ACCESS_LOCAL_WRITE;
- } else if (!(devattr.device_cap_flags &
- IB_DEVICE_LOCAL_DMA_LKEY)) {
- need_dma_mr = 1;
- dma_mr_acc = IB_ACCESS_LOCAL_WRITE;
- } else
- need_dma_mr = 0;
- break;
- default:
+ if (!rdma_protocol_iwarp(newxprt->sc_cm_id->device,
+ newxprt->sc_cm_id->port_num) &&
+ !rdma_ib_or_iboe(newxprt->sc_cm_id->device,
+ newxprt->sc_cm_id->port_num))
goto errout;
+
+ if (!(newxprt->sc_dev_caps & SVCRDMA_DEVCAP_FAST_REG) ||
+ !(devattr.device_cap_flags & IB_DEVICE_LOCAL_DMA_LKEY)) {
+ need_dma_mr = 1;
+ dma_mr_acc = IB_ACCESS_LOCAL_WRITE;
+ if (rdma_protocol_iwarp(newxprt->sc_cm_id->device,
+ newxprt->sc_cm_id->port_num) &&
+ !(newxprt->sc_dev_caps & SVCRDMA_DEVCAP_FAST_REG))
+ dma_mr_acc |= IB_ACCESS_REMOTE_WRITE;
}
+ if (rdma_protocol_iwarp(newxprt->sc_cm_id->device,
+ newxprt->sc_cm_id->port_num))
+ newxprt->sc_dev_caps |= SVCRDMA_DEVCAP_READ_W_INV;
+
/* Create the DMA MR if needed, otherwise, use the DMA LKEY */
if (need_dma_mr) {
/* Register all of physical memory */
--
2.1.0
next prev parent reply other threads:[~2015-04-28 15:10 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 15:10 [PATCH v7 00/23] IB/Verbs: IB Management Helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 01/23] IB/Verbs: Implement new callback query_protocol() Michael Wang
2015-04-28 15:10 ` [PATCH v7 04/23] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-28 19:02 ` Or Gerlitz
[not found] ` <CAJ3xEMhOg1xh5dXburjavqcy3crwWs6OoF2qEojiDxDhT-MCDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-29 7:40 ` Michael Wang
2015-04-29 8:17 ` Or Gerlitz
2015-04-29 15:48 ` Or Gerlitz
2015-04-30 7:28 ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 05/23] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-28 15:10 ` [PATCH v7 06/23] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-28 15:10 ` [PATCH v7 07/23] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-28 15:10 ` Michael Wang [this message]
2015-04-28 15:10 ` [PATCH v7 09/23] IB/Verbs: Reform IB-core verbs Michael Wang
2015-04-28 15:10 ` [PATCH v7 12/23] IB/Verbs: Reform mcast related part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 13/23] IB/Verbs: Reform cma_acquire_dev() Michael Wang
[not found] ` <1430233823-7075-1-git-send-email-yun.wang-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-28 15:10 ` [PATCH v7 02/23] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-28 15:10 ` [PATCH v7 03/23] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-28 15:10 ` [PATCH v7 10/23] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-28 15:10 ` [PATCH v7 11/23] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-28 15:10 ` [PATCH v7 14/23] IB/Verbs: Reform rest " Michael Wang
2015-04-28 15:10 ` [PATCH v7 15/23] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-28 15:10 ` [PATCH v7 21/23] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-28 15:10 ` [PATCH v7 22/23] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-28 15:10 ` [PATCH v7 23/23] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-05-01 6:34 ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers ira.weiny
[not found] ` <20150501063428.GA30098-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-01 16:24 ` Hefty, Sean
2015-05-01 16:27 ` Weiny, Ira
2015-05-04 7:36 ` Michael Wang
2015-04-28 15:10 ` [PATCH v7 16/23] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-28 15:10 ` [PATCH v7 17/23] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 18/23] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-28 15:10 ` [PATCH v7 19/23] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-28 15:10 ` [PATCH v7 20/23] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-29 16:28 ` [PATCH v7 00/23] IB/Verbs: IB Management Helpers Doug Ledford
[not found] ` <1430324895.102408.23.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30 5:40 ` Or Gerlitz
[not found] ` <5541C044.7090800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30 7:00 ` Doug Ledford
[not found] ` <1430377216.102408.47.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-30 7:24 ` Or Gerlitz
[not found] ` <5541D8CB.8050305-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30 8:11 ` Michael Wang
[not found] ` <5541E3BE.2080708-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2015-04-30 8:23 ` Or Gerlitz
[not found] ` <5541E67E.4030906-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-04-30 8:28 ` Michael Wang
2015-04-30 7:48 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430233823-7075-9-git-send-email-yun.wang@profitbricks.com \
--to=yun.wang@profitbricks.com \
--cc=Devesh.Sharma@Emulex.Com \
--cc=dgoodell@cisco.com \
--cc=dledford@redhat.com \
--cc=eli@mellanox.com \
--cc=faisal.latif@intel.com \
--cc=haggaie@mellanox.com \
--cc=hal@dev.mellanox.co.il \
--cc=hnguyen@de.ibm.com \
--cc=infinipath@intel.com \
--cc=ira.weiny@intel.com \
--cc=jackm@dev.mellanox.co.il \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=raisch@de.ibm.com \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=swise@opengridcomputing.com \
--cc=tom@opengridcomputing.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox