Re: [RFC PATCH 3/5] IB/core: Convert cap_ib_mad to core_cap_flags bit mask

Michael Wang
2015-05-05T08:00:13Z

On 05/05/2015 12:43 AM, ira.weiny wrote:
[snip]
>
>>
>>> static inline int cap_ib_mad(struct ib_device *device, u8 port_num)
>>> {
>>> - return rdma_ib_or_iboe(device, port_num);
>>> + return !!(device->core_cap_flags[port_num] & RDMA_CORE_CAP_IB_MAD);
>>
>>
>> 'bool' is OK in the kernel, just use that instead of !! - in fact all of
>> thse cap returns should return bool. Michael should fix that in his
>> series too.
>
> Michael?

Ok, I will use bool in next version :-)

Regards,
Michael Wang

>
> Ira