Re: [PATCH] IB/qib: fix test of unsigned variable

[Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>]

Hi,

Le lundi 11 mai 2015 à 08:13 -0400, Mike Marciniszyn a écrit :
> Commit d4988623cc60 ("IB/qib: use arch_phys_wc_add()")
> adjusted mtrr inititialization to use the new interface.
> 
> Unfortunately, the new interface returns a signed
> value and the patch tested the unsigned wc_cookie.
> 
> Fix the issue by using 'ret' and only assigning
> wc_cookie from ret when ret >= 0.   Additionally, insure
> ret is 0 on success.
> 
> Signed-off-by: Mike Marciniszyn <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Cc: Luis R. Rodriguez <mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
Cc: Luis R. Rodriguez <mcgrof-IBi9RG/b67k@public.gmane.org>

> ---
>  drivers/infiniband/hw/qib/qib_wc_x86_64.c |    8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_wc_x86_64.c b/drivers/infiniband/hw/qib/qib_wc_x86_64.c
> index 6d61ef9..85525be 100644
> --- a/drivers/infiniband/hw/qib/qib_wc_x86_64.c
> +++ b/drivers/infiniband/hw/qib/qib_wc_x86_64.c
> @@ -116,9 +116,11 @@ int qib_enable_wc(struct qib_devdata *dd)
>  	}
>  
>  	if (!ret) {
> -		dd->wc_cookie = arch_phys_wc_add(pioaddr, piolen);
> -		if (dd->wc_cookie < 0)
> -			ret = -EINVAL;
> +		ret = arch_phys_wc_add(pioaddr, piolen);
> +		if (ret >= 0) {
> +			dd->wc_cookie = ret;
> +			ret = 0;
> +		}
>  	}
>  
>  	return ret;
> 

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html