From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Droneaud Subject: Re: [PATCH v4 2/2] ulps: Align several ULPs to use core/rdma_cm logging helpers Date: Tue, 12 May 2015 13:52:50 +0200 Message-ID: <1431431570.25060.62.camel@opteya.com> References: <1431425527-30114-1-git-send-email-sagig@mellanox.com> <1431425527-30114-3-git-send-email-sagig@mellanox.com> <1431428675.25060.48.camel@opteya.com> <5551E4A0.3050405@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5551E4A0.3050405-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hi, Le mardi 12 mai 2015 =C3=A0 14:31 +0300, Sagi Grimberg a =C3=A9crit : > On 5/12/2015 2:04 PM, Yann Droneaud wrote: > > Le mardi 12 mai 2015 =C3=A0 13:12 +0300, Sagi Grimberg a =C3=A9crit= : > >> Remove rds & xprtrdma specific helpers and have them and > >> srp, iser, isert use the generic helpers. While we're at it > >> align svcrdma as well. > >> > >> Reviewed-by: Bart Van Assche > >> Reviewed-by: Chuck Lever > >> Signed-off-by: Sagi Grimberg > >> Signed-off-by: Anna Schumaker > > > > That's quite a big patch. Why not splitting it per ulp ? >=20 > Its just cosmetics, I can do it though... >=20 It could also help to separate changes to replace existing from changes to add new items in the log. > > > > Anyway, is changing the format of the messages going to break some > > userspace trying to parse those ? > > >=20 > I don't think logging is something that user-space should rely on > to be unmodified forever. It was just a little remainder for people reviewing the patches. https://xkcd.com/1172/ It's always surprising how one can use a "non-feature" and rely on it. Regards. --=20 Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html