Re: [PATCH 5/5] IB/core: Convert management helpers to core capability bits

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

On Thu, 2015-05-14 at 12:26 -0400, ira.weiny wrote:
> On Thu, May 14, 2015 at 04:10:24PM +0000, Weiny, Ira wrote:
> > > >  static inline bool rdma_protocol_ib(struct ib_device *device, u8
> > > > port_num)  {
> > > > -	return device->query_protocol(device, port_num) ==
> > > RDMA_PROTOCOL_IB;
> > > > +	return device->port_immutable[port_num].core_cap_flags &
> > > > +RDMA_CORE_CAP_PROT_IB;
> > > >  }
> > > >
> > > >  static inline bool rdma_protocol_iboe(struct ib_device *device, u8
> > > > port_num)
> > > 
> > > Should this helper be renamed rdma_protocol_roce (and change any
> > > consumers of this helper to use that name) ? If so, should it be done in this
> > > patch or follow on patch ?
> > > 
> > 
> > I'll create a follow on patch.
> > 
> 
> Since we are going down this path perhaps someone can change all the other iboe
> references.  These counts were after changing the rdma_protocol_* names.
> 
> 12:24:45 > grep -r iboe drivers/infiniband/ | grep -v Binary | wc -l
> 123
> 
> 12:24:51 > grep -r iboe include/rdma | grep -v Binary | wc -l
> 4

No biggie, I'll take care of it.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]