Re: [PATCH] IB/core: Change rdma_protcol_iboe to roce

[Yann Droneaud <ydroneaud-RlY5vtjFyJ3QT0dZR+AlfA@public.gmane.org>]

Hi,

Le vendredi 15 mai 2015 à 16:29 +0000, Weiny, Ira a écrit :
> > Le jeudi 14 mai 2015 à 15:01 -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org a écrit :
> > > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > >
> > > It has been decided that ROCE should be used within the kernel rather
> > > than IBOE as we used before.  Change iboe to roce on the new
> > rdma_protocol_* functions.
> > >
> > 
> > Erk ... What's the usefulness of such patch 
> 
> Currently there is inconsistency in the naming of the RoCE technology.
> 
> 12:27:35 > grep -r roce drivers/infiniband | grep -v Binary | grep -i -v proce | wc -l
> 85
> 
> All in the driver code.
> 
> 12:27:48 > grep -r iboe drivers/infiniband | grep -v Binary | wc -l
> 130
> 
> Mainly in the core and mlx4 driver.
> 

I see thing a bit differently:

$ grep -ri 'roce' include/rdma/ \
                  include/uapi/rdma \
                  include/uapi/linux/if_infiniband.h \
                  drivers/infiniband/core | grep -vi proce | wc -l
0

$ grep -ri 'iboe' include/rdma/ \
                  include/uapi/rdma \
                  include/uapi/linux/if_infiniband.h \
                  drivers/infiniband/core | grep -vi proce | wc -l
30

(On next-20150515).

I believe the drivers can have the names they want, especially ocrdma,
Emulex OneConnect RoCE.

> This patch was to clean up the management helper function as a general
> move toward standardizing on roce rather than iboe.  Most people in
> the community refer to this as "RoCE" so that name was chosen to move
> to.
> 

It's not the first time Linux use a name not matching the "vendor" one,
amd64, arm64, etc.

> > 
> > IBoE is used throughout the IB/RDMA subsystem.
> > 
> > Changing only these occurences is rather inconsistent.
> > 
> 
> I asked about changing all the references and Doug mentioned he would
> make a patch to change the other references.  Personally I don't want
> to see a massive rename patch but this could be done.
> 

That's my main concern: I dislike patch that change such large portion
of code, for not well defined purpose.

I think "It has been decided that ROCE should be used within" is not
enough to justify the change.

But "Most people in the community refer to this as "RoCE" so that name
was chosen to move to." sound a bit better as an explanation.

And now, I'm stopping bikeshedding :)

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html