* [PATCH 0/3] Add const to various core functions
@ 2015-05-21 20:40 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 15+ messages in thread
From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ira Weiny
From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
In order to support some of Jason's comments to add const to the functions I am
adding for OPA the following patches clean up the call trees of the currently
defined functions.
They stand on their own as clean up patches. Therefore, I am submitting them
separately from the OPA patches.
Ira Weiny (3):
IB/core: Add const to RDMA helpers
IB/core: Add const to device process_mad
IB/core: Add const to agent_send_response
drivers/infiniband/core/addr.c | 4 +--
drivers/infiniband/core/agent.c | 8 +++---
drivers/infiniband/core/agent.h | 4 +--
drivers/infiniband/core/cache.c | 8 +++---
drivers/infiniband/core/verbs.c | 9 ++++---
drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++---
drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++---
drivers/infiniband/hw/cxgb4/provider.c | 5 ++--
drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +--
drivers/infiniband/hw/ehca/ehca_sqp.c | 4 +--
drivers/infiniband/hw/ipath/ipath_mad.c | 8 +++---
drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++---
drivers/infiniband/hw/mlx4/mad.c | 21 ++++++++-------
drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 +++---
drivers/infiniband/hw/mlx5/mad.c | 8 +++---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +++---
drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +--
drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +--
drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++---
drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++----
drivers/infiniband/hw/nes/nes_verbs.c | 4 +--
drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++---
drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++---
drivers/infiniband/hw/qib/qib_mad.c | 10 +++----
drivers/infiniband/hw/qib/qib_verbs.h | 4 +--
drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +-
include/linux/mlx5/driver.h | 2 +-
include/rdma/ib_addr.h | 6 ++---
include/rdma/ib_cache.h | 8 +++---
include/rdma/ib_verbs.h | 39 ++++++++++++++-------------
30 files changed, 116 insertions(+), 112 deletions(-)
--
1.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread[parent not found: <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* [PATCH 1/3] IB/core: Add const to RDMA helpers [not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2015-05-21 20:40 ` ira.weiny-ral2JQCrhuEAvxtiuMwx3w 2015-05-21 20:40 ` [PATCH 2/3] IB/core: Add const to device process_mad ira.weiny-ral2JQCrhuEAvxtiuMwx3w ` (2 subsequent siblings) 3 siblings, 0 replies; 15+ messages in thread From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 UTC (permalink / raw) To: dledford-H+wXaHxf7aLQT0dZR+AlfA Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ira Weiny From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> The ib_device passed to the new RDMA helpers is constant. Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- include/rdma/ib_verbs.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index ad499bda62a4..f19739adf80d 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1831,22 +1831,22 @@ static inline u8 rdma_end_port(const struct ib_device *device) 0 : device->phys_port_cnt; } -static inline bool rdma_protocol_ib(struct ib_device *device, u8 port_num) +static inline bool rdma_protocol_ib(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_PROT_IB; } -static inline bool rdma_protocol_roce(struct ib_device *device, u8 port_num) +static inline bool rdma_protocol_roce(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_PROT_ROCE; } -static inline bool rdma_protocol_iwarp(struct ib_device *device, u8 port_num) +static inline bool rdma_protocol_iwarp(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_PROT_IWARP; } -static inline bool rdma_ib_or_roce(struct ib_device *device, u8 port_num) +static inline bool rdma_ib_or_roce(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & (RDMA_CORE_CAP_PROT_IB | RDMA_CORE_CAP_PROT_ROCE); @@ -1864,7 +1864,7 @@ static inline bool rdma_ib_or_roce(struct ib_device *device, u8 port_num) * * Return: true if the port supports sending/receiving of MAD packets. */ -static inline bool rdma_cap_ib_mad(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_ib_mad(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_IB_MAD; } @@ -1889,7 +1889,7 @@ static inline bool rdma_cap_ib_mad(struct ib_device *device, u8 port_num) * * Return: true if the port provides an SMI. */ -static inline bool rdma_cap_ib_smi(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_ib_smi(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_IB_SMI; } @@ -1909,7 +1909,7 @@ static inline bool rdma_cap_ib_smi(struct ib_device *device, u8 port_num) * Return: true if the port supports an IB CM (this does not guarantee that * a CM is actually running however). */ -static inline bool rdma_cap_ib_cm(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_ib_cm(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_IB_CM; } @@ -1926,7 +1926,7 @@ static inline bool rdma_cap_ib_cm(struct ib_device *device, u8 port_num) * Return: true if the port supports an iWARP CM (this does not guarantee that * a CM is actually running however). */ -static inline bool rdma_cap_iw_cm(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_iw_cm(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_IW_CM; } @@ -1946,7 +1946,7 @@ static inline bool rdma_cap_iw_cm(struct ib_device *device, u8 port_num) * Administration interface. This does not imply that the SA service is * running locally. */ -static inline bool rdma_cap_ib_sa(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_ib_sa(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_IB_SA; } @@ -1968,7 +1968,7 @@ static inline bool rdma_cap_ib_sa(struct ib_device *device, u8 port_num) * overhead of registering/unregistering with the SM and tracking of the * total number of queue pairs attached to the multicast group. */ -static inline bool rdma_cap_ib_mcast(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_ib_mcast(const struct ib_device *device, u8 port_num) { return rdma_cap_ib_sa(device, port_num); } @@ -1986,7 +1986,7 @@ static inline bool rdma_cap_ib_mcast(struct ib_device *device, u8 port_num) * Return: true if the port uses a GID address to identify devices on the * network. */ -static inline bool rdma_cap_af_ib(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_af_ib(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_AF_IB; } @@ -2007,7 +2007,7 @@ static inline bool rdma_cap_af_ib(struct ib_device *device, u8 port_num) * addition of a Global Route Header built from our Ethernet Address * Handle into our header list for connectionless packets. */ -static inline bool rdma_cap_eth_ah(struct ib_device *device, u8 port_num) +static inline bool rdma_cap_eth_ah(const struct ib_device *device, u8 port_num) { return device->port_immutable[port_num].core_cap_flags & RDMA_CORE_CAP_ETH_AH; } -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/3] IB/core: Add const to device process_mad [not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2015-05-21 20:40 ` [PATCH 1/3] IB/core: Add const to RDMA helpers ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 ` ira.weiny-ral2JQCrhuEAvxtiuMwx3w 2015-05-21 20:40 ` [PATCH 3/3] IB/core: Add const to agent_send_response ira.weiny-ral2JQCrhuEAvxtiuMwx3w 2015-05-29 4:13 ` [PATCH 0/3] Add const to various core functions ira.weiny 3 siblings, 0 replies; 15+ messages in thread From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 UTC (permalink / raw) To: dledford-H+wXaHxf7aLQT0dZR+AlfA Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ira Weiny From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> The process_mad device function declares some parameters as "in". Make those parameters const and adjust the call tree under process_mad in the various drivers accordingly. Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- drivers/infiniband/hw/amso1100/c2_provider.c | 6 +++--- drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 +++--- drivers/infiniband/hw/cxgb4/provider.c | 5 +++-- drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 ++-- drivers/infiniband/hw/ehca/ehca_sqp.c | 4 ++-- drivers/infiniband/hw/ipath/ipath_mad.c | 8 ++++---- drivers/infiniband/hw/ipath/ipath_verbs.h | 6 +++--- drivers/infiniband/hw/mlx4/mad.c | 21 +++++++++++---------- drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 ++++---- drivers/infiniband/hw/mlx5/mad.c | 8 ++++---- drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 ++++---- drivers/infiniband/hw/mthca/mthca_cmd.c | 4 ++-- drivers/infiniband/hw/mthca/mthca_cmd.h | 4 ++-- drivers/infiniband/hw/mthca/mthca_dev.h | 6 +++--- drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++++----- drivers/infiniband/hw/nes/nes_verbs.c | 4 ++-- drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 +++--- drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 +++--- drivers/infiniband/hw/qib/qib_mad.c | 10 +++++----- drivers/infiniband/hw/qib/qib_verbs.h | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- include/linux/mlx5/driver.h | 2 +- include/rdma/ib_verbs.h | 6 +++--- 23 files changed, 75 insertions(+), 73 deletions(-) diff --git a/drivers/infiniband/hw/amso1100/c2_provider.c b/drivers/infiniband/hw/amso1100/c2_provider.c index d396c39918de..0f007a6b188b 100644 --- a/drivers/infiniband/hw/amso1100/c2_provider.c +++ b/drivers/infiniband/hw/amso1100/c2_provider.c @@ -582,9 +582,9 @@ static int c2_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) static int c2_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { pr_debug("%s:%u\n", __func__, __LINE__); return -ENOSYS; diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c index 061ef08c92e2..19c830ecbb67 100644 --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c @@ -85,9 +85,9 @@ static int iwch_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) static int iwch_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { return -ENOSYS; } diff --git a/drivers/infiniband/hw/cxgb4/provider.c b/drivers/infiniband/hw/cxgb4/provider.c index ef08a9f29451..75ea26a32076 100644 --- a/drivers/infiniband/hw/cxgb4/provider.c +++ b/drivers/infiniband/hw/cxgb4/provider.c @@ -80,8 +80,9 @@ static int c4iw_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) } static int c4iw_process_mad(struct ib_device *ibdev, int mad_flags, - u8 port_num, struct ib_wc *in_wc, - struct ib_grh *in_grh, struct ib_mad *in_mad, + u8 port_num, const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { return -ENOSYS; diff --git a/drivers/infiniband/hw/ehca/ehca_iverbs.h b/drivers/infiniband/hw/ehca/ehca_iverbs.h index 077185b3fbd6..582fc71a8488 100644 --- a/drivers/infiniband/hw/ehca/ehca_iverbs.h +++ b/drivers/infiniband/hw/ehca/ehca_iverbs.h @@ -191,8 +191,8 @@ int ehca_dealloc_ucontext(struct ib_ucontext *context); int ehca_mmap(struct ib_ucontext *context, struct vm_area_struct *vma); int ehca_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); void ehca_poll_eqs(unsigned long data); diff --git a/drivers/infiniband/hw/ehca/ehca_sqp.c b/drivers/infiniband/hw/ehca/ehca_sqp.c index dba8f9f8b996..765d62d43a30 100644 --- a/drivers/infiniband/hw/ehca/ehca_sqp.c +++ b/drivers/infiniband/hw/ehca/ehca_sqp.c @@ -217,8 +217,8 @@ perf_reply: } int ehca_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { int ret; diff --git a/drivers/infiniband/hw/ipath/ipath_mad.c b/drivers/infiniband/hw/ipath/ipath_mad.c index e890e5ba0e01..9e8929e23740 100644 --- a/drivers/infiniband/hw/ipath/ipath_mad.c +++ b/drivers/infiniband/hw/ipath/ipath_mad.c @@ -1257,7 +1257,7 @@ static int recv_pma_set_portcounters_ext(struct ib_pma_mad *pmp, } static int process_subn(struct ib_device *ibdev, int mad_flags, - u8 port_num, struct ib_mad *in_mad, + u8 port_num, const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct ib_smp *smp = (struct ib_smp *)out_mad; @@ -1389,7 +1389,7 @@ bail: } static int process_perf(struct ib_device *ibdev, u8 port_num, - struct ib_mad *in_mad, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct ib_pma_mad *pmp = (struct ib_pma_mad *)out_mad; @@ -1490,8 +1490,8 @@ bail: * This is called by the ib_mad module. */ int ipath_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { int ret; diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.h b/drivers/infiniband/hw/ipath/ipath_verbs.h index ae6cff4abffc..7a2b6a17f844 100644 --- a/drivers/infiniband/hw/ipath/ipath_verbs.h +++ b/drivers/infiniband/hw/ipath/ipath_verbs.h @@ -701,9 +701,9 @@ static inline void ipath_schedule_send(struct ipath_qp *qp) int ipath_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad); + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); /* * Compare the lower 24 bits of the two values. diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c index 9cd2b002d7ae..614ac6f07ae1 100644 --- a/drivers/infiniband/hw/mlx4/mad.c +++ b/drivers/infiniband/hw/mlx4/mad.c @@ -111,8 +111,9 @@ __be64 mlx4_ib_get_new_demux_tid(struct mlx4_ib_demux_ctx *ctx) } int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int mad_ifc_flags, - int port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad) + int port, const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const void *in_mad, void *response_mad) { struct mlx4_cmd_mailbox *inmailbox, *outmailbox; void *inbox; @@ -220,7 +221,7 @@ static void update_sm_ah(struct mlx4_ib_dev *dev, u8 port_num, u16 lid, u8 sl) * Snoop SM MADs for port info, GUID info, and P_Key table sets, so we can * synthesize LID change, Client-Rereg, GID change, and P_Key change events. */ -static void smp_snoop(struct ib_device *ibdev, u8 port_num, struct ib_mad *mad, +static void smp_snoop(struct ib_device *ibdev, u8 port_num, const struct ib_mad *mad, u16 prev_lid) { struct ib_port_info *pinfo; @@ -356,7 +357,7 @@ static void node_desc_override(struct ib_device *dev, } } -static void forward_trap(struct mlx4_ib_dev *dev, u8 port_num, struct ib_mad *mad) +static void forward_trap(struct mlx4_ib_dev *dev, u8 port_num, const struct ib_mad *mad) { int qpn = mad->mad_hdr.mgmt_class != IB_MGMT_CLASS_SUBN_LID_ROUTED; struct ib_mad_send_buf *send_buf; @@ -722,8 +723,8 @@ static int mlx4_ib_demux_mad(struct ib_device *ibdev, u8 port, } static int ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { u16 slid, prev_lid = 0; int err; @@ -825,8 +826,8 @@ static void edit_counter(struct mlx4_counter *cnt, } static int iboe_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct mlx4_cmd_mailbox *mailbox; struct mlx4_ib_dev *dev = to_mdev(ibdev); @@ -866,8 +867,8 @@ static int iboe_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, } int mlx4_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { switch (rdma_port_get_link_layer(ibdev, port_num)) { case IB_LINK_LAYER_INFINIBAND: diff --git a/drivers/infiniband/hw/mlx4/mlx4_ib.h b/drivers/infiniband/hw/mlx4/mlx4_ib.h index fce3934372a1..645d55ef0604 100644 --- a/drivers/infiniband/hw/mlx4/mlx4_ib.h +++ b/drivers/infiniband/hw/mlx4/mlx4_ib.h @@ -706,11 +706,11 @@ int mlx4_ib_post_recv(struct ib_qp *ibqp, struct ib_recv_wr *wr, struct ib_recv_wr **bad_wr); int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int mad_ifc_flags, - int port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad); + int port, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const void *in_mad, void *response_mad); int mlx4_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad); + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); int mlx4_ib_mad_init(struct mlx4_ib_dev *dev); void mlx4_ib_mad_cleanup(struct mlx4_ib_dev *dev); diff --git a/drivers/infiniband/hw/mlx5/mad.c b/drivers/infiniband/hw/mlx5/mad.c index 9cf9a37bb5ff..34e519cd4c64 100644 --- a/drivers/infiniband/hw/mlx5/mad.c +++ b/drivers/infiniband/hw/mlx5/mad.c @@ -41,8 +41,8 @@ enum { }; int mlx5_MAD_IFC(struct mlx5_ib_dev *dev, int ignore_mkey, int ignore_bkey, - u8 port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad) + u8 port, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const void *in_mad, void *response_mad) { u8 op_modifier = 0; @@ -58,8 +58,8 @@ int mlx5_MAD_IFC(struct mlx5_ib_dev *dev, int ignore_mkey, int ignore_bkey, } int mlx5_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { u16 slid; int err; diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h index dff1cfcdf476..c6219032d00c 100644 --- a/drivers/infiniband/hw/mlx5/mlx5_ib.h +++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h @@ -525,8 +525,8 @@ void __mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq) void mlx5_ib_cq_clean(struct mlx5_ib_cq *cq, u32 qpn, struct mlx5_ib_srq *srq); void mlx5_ib_free_srq_wqe(struct mlx5_ib_srq *srq, int wqe_index); int mlx5_MAD_IFC(struct mlx5_ib_dev *dev, int ignore_mkey, int ignore_bkey, - u8 port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad); + u8 port, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const void *in_mad, void *response_mad); struct ib_ah *create_ib_ah(struct ib_ah_attr *ah_attr, struct mlx5_ib_ah *ah); struct ib_ah *mlx5_ib_create_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr); @@ -586,8 +586,8 @@ int mlx5_ib_map_phys_fmr(struct ib_fmr *ibfmr, u64 *page_list, int mlx5_ib_unmap_fmr(struct list_head *fmr_list); int mlx5_ib_fmr_dealloc(struct ib_fmr *ibfmr); int mlx5_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad); + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); struct ib_xrcd *mlx5_ib_alloc_xrcd(struct ib_device *ibdev, struct ib_ucontext *context, struct ib_udata *udata); diff --git a/drivers/infiniband/hw/mthca/mthca_cmd.c b/drivers/infiniband/hw/mthca/mthca_cmd.c index 9d3e5c1ac60e..c7f49bbb0c72 100644 --- a/drivers/infiniband/hw/mthca/mthca_cmd.c +++ b/drivers/infiniband/hw/mthca/mthca_cmd.c @@ -1858,8 +1858,8 @@ int mthca_CONF_SPECIAL_QP(struct mthca_dev *dev, int type, u32 qpn) } int mthca_MAD_IFC(struct mthca_dev *dev, int ignore_mkey, int ignore_bkey, - int port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad) + int port, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const void *in_mad, void *response_mad) { struct mthca_mailbox *inmailbox, *outmailbox; void *inbox; diff --git a/drivers/infiniband/hw/mthca/mthca_cmd.h b/drivers/infiniband/hw/mthca/mthca_cmd.h index f952244c54de..d2e5b194b938 100644 --- a/drivers/infiniband/hw/mthca/mthca_cmd.h +++ b/drivers/infiniband/hw/mthca/mthca_cmd.h @@ -312,8 +312,8 @@ int mthca_QUERY_QP(struct mthca_dev *dev, u32 num, int is_ee, struct mthca_mailbox *mailbox); int mthca_CONF_SPECIAL_QP(struct mthca_dev *dev, int type, u32 qpn); int mthca_MAD_IFC(struct mthca_dev *dev, int ignore_mkey, int ignore_bkey, - int port, struct ib_wc *in_wc, struct ib_grh *in_grh, - void *in_mad, void *response_mad); + int port, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const void *in_mad, void *response_mad); int mthca_READ_MGM(struct mthca_dev *dev, int index, struct mthca_mailbox *mailbox); int mthca_WRITE_MGM(struct mthca_dev *dev, int index, diff --git a/drivers/infiniband/hw/mthca/mthca_dev.h b/drivers/infiniband/hw/mthca/mthca_dev.h index 7e6a6d64ad4e..b70f9ff23171 100644 --- a/drivers/infiniband/hw/mthca/mthca_dev.h +++ b/drivers/infiniband/hw/mthca/mthca_dev.h @@ -576,9 +576,9 @@ int mthca_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid); int mthca_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); int mthca_create_agents(struct mthca_dev *dev); void mthca_free_agents(struct mthca_dev *dev); diff --git a/drivers/infiniband/hw/mthca/mthca_mad.c b/drivers/infiniband/hw/mthca/mthca_mad.c index 8881fa376e06..d54608ca0820 100644 --- a/drivers/infiniband/hw/mthca/mthca_mad.c +++ b/drivers/infiniband/hw/mthca/mthca_mad.c @@ -104,7 +104,7 @@ static void update_sm_ah(struct mthca_dev *dev, */ static void smp_snoop(struct ib_device *ibdev, u8 port_num, - struct ib_mad *mad, + const struct ib_mad *mad, u16 prev_lid) { struct ib_event event; @@ -160,7 +160,7 @@ static void node_desc_override(struct ib_device *dev, static void forward_trap(struct mthca_dev *dev, u8 port_num, - struct ib_mad *mad) + const struct ib_mad *mad) { int qpn = mad->mad_hdr.mgmt_class != IB_MGMT_CLASS_SUBN_LID_ROUTED; struct ib_mad_send_buf *send_buf; @@ -195,9 +195,9 @@ static void forward_trap(struct mthca_dev *dev, int mthca_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { int err; diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers/infiniband/hw/nes/nes_verbs.c index 05530e3f6ff0..0099e419e24f 100644 --- a/drivers/infiniband/hw/nes/nes_verbs.c +++ b/drivers/infiniband/hw/nes/nes_verbs.c @@ -3221,8 +3221,8 @@ static int nes_multicast_detach(struct ib_qp *ibqp, union ib_gid *gid, u16 lid) * nes_process_mad */ static int nes_process_mad(struct ib_device *ibdev, int mad_flags, - u8 port_num, struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + u8 port_num, const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { nes_debug(NES_DBG_INIT, "\n"); return -ENOSYS; diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c index d812904f3984..3216bce08a10 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c @@ -196,9 +196,9 @@ int ocrdma_modify_ah(struct ib_ah *ibah, struct ib_ah_attr *attr) int ocrdma_process_mad(struct ib_device *ibdev, int process_mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { int status; struct ocrdma_dev *dev; diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h index 726a87cf22dc..5c4ae3eba47c 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h @@ -42,7 +42,7 @@ int ocrdma_modify_ah(struct ib_ah *, struct ib_ah_attr *); int ocrdma_process_mad(struct ib_device *, int process_mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad); + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); #endif /* __OCRDMA_AH_H__ */ diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c index 395f4046dba2..6ab8ab89d058 100644 --- a/drivers/infiniband/hw/qib/qib_mad.c +++ b/drivers/infiniband/hw/qib/qib_mad.c @@ -1854,7 +1854,7 @@ static int pma_set_portcounters_ext(struct ib_pma_mad *pmp, } static int process_subn(struct ib_device *ibdev, int mad_flags, - u8 port, struct ib_mad *in_mad, + u8 port, const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct ib_smp *smp = (struct ib_smp *)out_mad; @@ -2006,7 +2006,7 @@ bail: } static int process_perf(struct ib_device *ibdev, u8 port, - struct ib_mad *in_mad, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct ib_pma_mad *pmp = (struct ib_pma_mad *)out_mad; @@ -2299,7 +2299,7 @@ static int check_cc_key(struct qib_ibport *ibp, } static int process_cc(struct ib_device *ibdev, int mad_flags, - u8 port, struct ib_mad *in_mad, + u8 port, const struct ib_mad *in_mad, struct ib_mad *out_mad) { struct ib_cc_mad *ccp = (struct ib_cc_mad *)out_mad; @@ -2400,8 +2400,8 @@ bail: * This is called by the ib_mad module. */ int qib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad) + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad) { int ret; struct qib_ibport *ibp = to_iport(ibdev, port); diff --git a/drivers/infiniband/hw/qib/qib_verbs.h b/drivers/infiniband/hw/qib/qib_verbs.h index bfc8948fdd35..f2f57749c07d 100644 --- a/drivers/infiniband/hw/qib/qib_verbs.h +++ b/drivers/infiniband/hw/qib/qib_verbs.h @@ -872,8 +872,8 @@ void qib_cap_mask_chg(struct qib_ibport *ibp); void qib_sys_guid_chg(struct qib_ibport *ibp); void qib_node_desc_chg(struct qib_ibport *ibp); int qib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, - struct ib_wc *in_wc, struct ib_grh *in_grh, - struct ib_mad *in_mad, struct ib_mad *out_mad); + const struct ib_wc *in_wc, const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); int qib_create_agents(struct qib_ibdev *dev); void qib_free_agents(struct qib_ibdev *dev); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mad.c b/drivers/net/ethernet/mellanox/mlx5/core/mad.c index ee1b0b965f34..1368dac00da0 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/mad.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/mad.c @@ -36,7 +36,7 @@ #include <linux/mlx5/cmd.h> #include "mlx5_core.h" -int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, void *inb, void *outb, +int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, const void *inb, void *outb, u16 opmod, u8 port) { struct mlx5_mad_ifc_mbox_in *in = NULL; diff --git a/include/linux/mlx5/driver.h b/include/linux/mlx5/driver.h index 9a90e7523dc2..9ec7c93d6fa3 100644 --- a/include/linux/mlx5/driver.h +++ b/include/linux/mlx5/driver.h @@ -696,7 +696,7 @@ int mlx5_core_dump_fill_mkey(struct mlx5_core_dev *dev, struct mlx5_core_mr *mr, u32 *mkey); int mlx5_core_alloc_pd(struct mlx5_core_dev *dev, u32 *pdn); int mlx5_core_dealloc_pd(struct mlx5_core_dev *dev, u32 pdn); -int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, void *inb, void *outb, +int mlx5_core_mad_ifc(struct mlx5_core_dev *dev, const void *inb, void *outb, u16 opmod, u8 port); void mlx5_pagealloc_init(struct mlx5_core_dev *dev); void mlx5_pagealloc_cleanup(struct mlx5_core_dev *dev); diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index f19739adf80d..48c9acbea53e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1690,9 +1690,9 @@ struct ib_device { int (*process_mad)(struct ib_device *device, int process_mad_flags, u8 port_num, - struct ib_wc *in_wc, - struct ib_grh *in_grh, - struct ib_mad *in_mad, + const struct ib_wc *in_wc, + const struct ib_grh *in_grh, + const struct ib_mad *in_mad, struct ib_mad *out_mad); struct ib_xrcd * (*alloc_xrcd)(struct ib_device *device, struct ib_ucontext *ucontext, -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/3] IB/core: Add const to agent_send_response [not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2015-05-21 20:40 ` [PATCH 1/3] IB/core: Add const to RDMA helpers ira.weiny-ral2JQCrhuEAvxtiuMwx3w 2015-05-21 20:40 ` [PATCH 2/3] IB/core: Add const to device process_mad ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 ` ira.weiny-ral2JQCrhuEAvxtiuMwx3w 2015-05-29 4:13 ` [PATCH 0/3] Add const to various core functions ira.weiny 3 siblings, 0 replies; 15+ messages in thread From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-21 20:40 UTC (permalink / raw) To: dledford-H+wXaHxf7aLQT0dZR+AlfA Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ira Weiny From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> In order to support constant callers of agent_send_response we add const specifiers to the its pointer arguments. Adjust the call tree accordingly. Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- drivers/infiniband/core/addr.c | 4 ++-- drivers/infiniband/core/agent.c | 8 ++++---- drivers/infiniband/core/agent.h | 4 ++-- drivers/infiniband/core/cache.c | 8 ++++---- drivers/infiniband/core/verbs.c | 9 +++++---- include/rdma/ib_addr.h | 6 +++--- include/rdma/ib_cache.h | 8 ++++---- include/rdma/ib_verbs.h | 9 +++++---- 8 files changed, 29 insertions(+), 27 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 38339d220d7f..746cdf56bc76 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -457,8 +457,8 @@ static void resolve_cb(int status, struct sockaddr *src_addr, complete(&((struct resolve_cb_context *)context)->comp); } -int rdma_addr_find_dmac_by_grh(union ib_gid *sgid, union ib_gid *dgid, u8 *dmac, - u16 *vlan_id) +int rdma_addr_find_dmac_by_grh(const union ib_gid *sgid, const union ib_gid *dgid, + u8 *dmac, u16 *vlan_id) { int ret = 0; struct rdma_dev_addr dev_addr; diff --git a/drivers/infiniband/core/agent.c b/drivers/infiniband/core/agent.c index a6fc4d6dc7d7..e51ea76c2523 100644 --- a/drivers/infiniband/core/agent.c +++ b/drivers/infiniband/core/agent.c @@ -54,7 +54,7 @@ static DEFINE_SPINLOCK(ib_agent_port_list_lock); static LIST_HEAD(ib_agent_port_list); static struct ib_agent_port_private * -__ib_get_agent_port(struct ib_device *device, int port_num) +__ib_get_agent_port(const struct ib_device *device, int port_num) { struct ib_agent_port_private *entry; @@ -67,7 +67,7 @@ __ib_get_agent_port(struct ib_device *device, int port_num) } static struct ib_agent_port_private * -ib_get_agent_port(struct ib_device *device, int port_num) +ib_get_agent_port(const struct ib_device *device, int port_num) { struct ib_agent_port_private *entry; unsigned long flags; @@ -78,8 +78,8 @@ ib_get_agent_port(struct ib_device *device, int port_num) return entry; } -void agent_send_response(struct ib_mad *mad, struct ib_grh *grh, - struct ib_wc *wc, struct ib_device *device, +void agent_send_response(const struct ib_mad *mad, const struct ib_grh *grh, + const struct ib_wc *wc, const struct ib_device *device, int port_num, int qpn) { struct ib_agent_port_private *port_priv; diff --git a/drivers/infiniband/core/agent.h b/drivers/infiniband/core/agent.h index 6669287009c2..94b5fb5b3eef 100644 --- a/drivers/infiniband/core/agent.h +++ b/drivers/infiniband/core/agent.h @@ -44,8 +44,8 @@ extern int ib_agent_port_open(struct ib_device *device, int port_num); extern int ib_agent_port_close(struct ib_device *device, int port_num); -extern void agent_send_response(struct ib_mad *mad, struct ib_grh *grh, - struct ib_wc *wc, struct ib_device *device, +extern void agent_send_response(const struct ib_mad *mad, const struct ib_grh *grh, + const struct ib_wc *wc, const struct ib_device *device, int port_num, int qpn); #endif /* __AGENT_H_ */ diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c index 08921b34182c..871da832d016 100644 --- a/drivers/infiniband/core/cache.c +++ b/drivers/infiniband/core/cache.c @@ -85,10 +85,10 @@ int ib_get_cached_gid(struct ib_device *device, } EXPORT_SYMBOL(ib_get_cached_gid); -int ib_find_cached_gid(struct ib_device *device, - union ib_gid *gid, - u8 *port_num, - u16 *index) +int ib_find_cached_gid(struct ib_device *device, + const union ib_gid *gid, + u8 *port_num, + u16 *index) { struct ib_gid_cache *cache; unsigned long flags; diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index 685a362f6ed6..658c2835a11d 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -257,8 +257,9 @@ struct ib_ah *ib_create_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr) } EXPORT_SYMBOL(ib_create_ah); -int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, - struct ib_grh *grh, struct ib_ah_attr *ah_attr) +int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, + const struct ib_wc *wc, const struct ib_grh *grh, + struct ib_ah_attr *ah_attr) { u32 flow_class; u16 gid_index; @@ -307,8 +308,8 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, } EXPORT_SYMBOL(ib_init_ah_from_wc); -struct ib_ah *ib_create_ah_from_wc(struct ib_pd *pd, struct ib_wc *wc, - struct ib_grh *grh, u8 port_num) +struct ib_ah *ib_create_ah_from_wc(struct ib_pd *pd, const struct ib_wc *wc, + const struct ib_grh *grh, u8 port_num) { struct ib_ah_attr ah_attr; int ret; diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index ac54c27a2bfd..fde33ac6b58a 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_addr.h @@ -111,8 +111,8 @@ int rdma_copy_addr(struct rdma_dev_addr *dev_addr, struct net_device *dev, int rdma_addr_size(struct sockaddr *addr); int rdma_addr_find_smac_by_sgid(union ib_gid *sgid, u8 *smac, u16 *vlan_id); -int rdma_addr_find_dmac_by_grh(union ib_gid *sgid, union ib_gid *dgid, u8 *smac, - u16 *vlan_id); +int rdma_addr_find_dmac_by_grh(const union ib_gid *sgid, const union ib_gid *dgid, + u8 *smac, u16 *vlan_id); static inline u16 ib_addr_get_pkey(struct rdma_dev_addr *dev_addr) { @@ -160,7 +160,7 @@ static inline int rdma_ip2gid(struct sockaddr *addr, union ib_gid *gid) } /* Important - sockaddr should be a union of sockaddr_in and sockaddr_in6 */ -static inline void rdma_gid2ip(struct sockaddr *out, union ib_gid *gid) +static inline void rdma_gid2ip(struct sockaddr *out, const union ib_gid *gid) { if (ipv6_addr_v4mapped((struct in6_addr *)gid)) { struct sockaddr_in *out_in = (struct sockaddr_in *)out; diff --git a/include/rdma/ib_cache.h b/include/rdma/ib_cache.h index ad9a3c280944..bd92130f4ac5 100644 --- a/include/rdma/ib_cache.h +++ b/include/rdma/ib_cache.h @@ -64,10 +64,10 @@ int ib_get_cached_gid(struct ib_device *device, * ib_find_cached_gid() searches for the specified GID value in * the local software cache. */ -int ib_find_cached_gid(struct ib_device *device, - union ib_gid *gid, - u8 *port_num, - u16 *index); +int ib_find_cached_gid(struct ib_device *device, + const union ib_gid *gid, + u8 *port_num, + u16 *index); /** * ib_get_cached_pkey - Returns a cached PKey table entry diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 48c9acbea53e..7d78794ed189 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -2096,8 +2096,9 @@ struct ib_ah *ib_create_ah(struct ib_pd *pd, struct ib_ah_attr *ah_attr); * @ah_attr: Returned attributes that can be used when creating an address * handle for replying to the message. */ -int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, - struct ib_grh *grh, struct ib_ah_attr *ah_attr); +int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, + const struct ib_wc *wc, const struct ib_grh *grh, + struct ib_ah_attr *ah_attr); /** * ib_create_ah_from_wc - Creates an address handle associated with the @@ -2111,8 +2112,8 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, * The address handle is used to reference a local or global destination * in all UD QP post sends. */ -struct ib_ah *ib_create_ah_from_wc(struct ib_pd *pd, struct ib_wc *wc, - struct ib_grh *grh, u8 port_num); +struct ib_ah *ib_create_ah_from_wc(struct ib_pd *pd, const struct ib_wc *wc, + const struct ib_grh *grh, u8 port_num); /** * ib_modify_ah - Modifies the address vector associated with an address -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> ` (2 preceding siblings ...) 2015-05-21 20:40 ` [PATCH 3/3] IB/core: Add const to agent_send_response ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-29 4:13 ` ira.weiny [not found] ` <20150529041313.GA1603-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> 3 siblings, 1 reply; 15+ messages in thread From: ira.weiny @ 2015-05-29 4:13 UTC (permalink / raw) To: dledford-H+wXaHxf7aLQT0dZR+AlfA; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA On Thu, May 21, 2015 at 04:40:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Doug, Jason, Were there any issues with these clean ups? I think they stand on their own but I can add them to the OPA series if you prefer. Ira > > In order to support some of Jason's comments to add const to the functions I am > adding for OPA the following patches clean up the call trees of the currently > defined functions. > > They stand on their own as clean up patches. Therefore, I am submitting them > separately from the OPA patches. > > Ira Weiny (3): > IB/core: Add const to RDMA helpers > IB/core: Add const to device process_mad > IB/core: Add const to agent_send_response > > drivers/infiniband/core/addr.c | 4 +-- > drivers/infiniband/core/agent.c | 8 +++--- > drivers/infiniband/core/agent.h | 4 +-- > drivers/infiniband/core/cache.c | 8 +++--- > drivers/infiniband/core/verbs.c | 9 ++++--- > drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++--- > drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++--- > drivers/infiniband/hw/cxgb4/provider.c | 5 ++-- > drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +-- > drivers/infiniband/hw/ehca/ehca_sqp.c | 4 +-- > drivers/infiniband/hw/ipath/ipath_mad.c | 8 +++--- > drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++--- > drivers/infiniband/hw/mlx4/mad.c | 21 ++++++++------- > drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 +++--- > drivers/infiniband/hw/mlx5/mad.c | 8 +++--- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +++--- > drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +-- > drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +-- > drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++--- > drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++---- > drivers/infiniband/hw/nes/nes_verbs.c | 4 +-- > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++--- > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++--- > drivers/infiniband/hw/qib/qib_mad.c | 10 +++---- > drivers/infiniband/hw/qib/qib_verbs.h | 4 +-- > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- > include/linux/mlx5/driver.h | 2 +- > include/rdma/ib_addr.h | 6 ++--- > include/rdma/ib_cache.h | 8 +++--- > include/rdma/ib_verbs.h | 39 ++++++++++++++------------- > 30 files changed, 116 insertions(+), 112 deletions(-) > > -- > 1.8.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20150529041313.GA1603-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <20150529041313.GA1603-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> @ 2015-05-29 12:54 ` Doug Ledford [not found] ` <1432904099.114391.61.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Doug Ledford @ 2015-05-29 12:54 UTC (permalink / raw) To: ira.weiny; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 3513 bytes --] On Fri, 2015-05-29 at 00:13 -0400, ira.weiny wrote: > On Thu, May 21, 2015 at 04:40:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > Doug, Jason, > > Were there any issues with these clean ups? I haven't gotten to them yet. Your 14 patch OPA addition and this were on my queue for getting to relatively soonish. I *thought* this touched stuff that your 14 patch set also touched and so thought it needed to be on top of it, so that's part of the reason why I hadn't even looked at it yet (these emails are part of the "still new and unread" emails in my Inbox that seem to never get to 0 ;-). > I think they stand on their own but I can add them to the OPA series if you > prefer. Double check that they stand on their own. If they do, I'll review them separately. > Ira > > > > > In order to support some of Jason's comments to add const to the functions I am > > adding for OPA the following patches clean up the call trees of the currently > > defined functions. > > > > They stand on their own as clean up patches. Therefore, I am submitting them > > separately from the OPA patches. > > > > Ira Weiny (3): > > IB/core: Add const to RDMA helpers > > IB/core: Add const to device process_mad > > IB/core: Add const to agent_send_response > > > > drivers/infiniband/core/addr.c | 4 +-- > > drivers/infiniband/core/agent.c | 8 +++--- > > drivers/infiniband/core/agent.h | 4 +-- > > drivers/infiniband/core/cache.c | 8 +++--- > > drivers/infiniband/core/verbs.c | 9 ++++--- > > drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++--- > > drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++--- > > drivers/infiniband/hw/cxgb4/provider.c | 5 ++-- > > drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +-- > > drivers/infiniband/hw/ehca/ehca_sqp.c | 4 +-- > > drivers/infiniband/hw/ipath/ipath_mad.c | 8 +++--- > > drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++--- > > drivers/infiniband/hw/mlx4/mad.c | 21 ++++++++------- > > drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 +++--- > > drivers/infiniband/hw/mlx5/mad.c | 8 +++--- > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +++--- > > drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +-- > > drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +-- > > drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++--- > > drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++---- > > drivers/infiniband/hw/nes/nes_verbs.c | 4 +-- > > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++--- > > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++--- > > drivers/infiniband/hw/qib/qib_mad.c | 10 +++---- > > drivers/infiniband/hw/qib/qib_verbs.h | 4 +-- > > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- > > include/linux/mlx5/driver.h | 2 +- > > include/rdma/ib_addr.h | 6 ++--- > > include/rdma/ib_cache.h | 8 +++--- > > include/rdma/ib_verbs.h | 39 ++++++++++++++------------- > > 30 files changed, 116 insertions(+), 112 deletions(-) > > > > -- > > 1.8.2 > > -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: 0E572FDD [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <1432904099.114391.61.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <1432904099.114391.61.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-05-29 15:17 ` ira.weiny [not found] ` <20150529151735.GA5372-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: ira.weiny @ 2015-05-29 15:17 UTC (permalink / raw) To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA On Fri, May 29, 2015 at 08:54:59AM -0400, Doug Ledford wrote: > On Fri, 2015-05-29 at 00:13 -0400, ira.weiny wrote: > > On Thu, May 21, 2015 at 04:40:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > > > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > > > Doug, Jason, > > > > Were there any issues with these clean ups? > > I haven't gotten to them yet. Your 14 patch OPA addition and this were > on my queue for getting to relatively soonish. I *thought* this touched > stuff that your 14 patch set also touched and so thought it needed to be > on top of it, so that's part of the reason why I hadn't even looked at > it yet (these emails are part of the "still new and unread" emails in my > Inbox that seem to never get to 0 ;-). I understand. > > > I think they stand on their own but I can add them to the OPA series if you > > prefer. > > Double check that they stand on their own. If they do, I'll review them > separately. They do stand on their own and they are improvements even without the OPA code. They became precursors to the next OPA series because I am changing some core functions. In order to declare parameters of those core functions const the entire call chain required updating. Rather than mix that call chain clean up with the new OPA code I felt it would be easier to review these as separate clean up patches. If this is an unorthodox procedure, is there a better way to handle something like this? As more and more clean up becomes necessary in the core I don't want the OPA changes to become a huge patch series which is unwieldy to review and mostly cleanup. (If you count Michaels changes the "clean up" to the core which OPA now relies on count for more patches then the actual OPA changes.) I'm trying to reduce the review workload by making clear which patches are clean up vs actual OPA code. Apologies, Ira > > > Ira > > > > > > > > In order to support some of Jason's comments to add const to the functions I am > > > adding for OPA the following patches clean up the call trees of the currently > > > defined functions. > > > > > > They stand on their own as clean up patches. Therefore, I am submitting them > > > separately from the OPA patches. > > > > > > Ira Weiny (3): > > > IB/core: Add const to RDMA helpers > > > IB/core: Add const to device process_mad > > > IB/core: Add const to agent_send_response > > > > > > drivers/infiniband/core/addr.c | 4 +-- > > > drivers/infiniband/core/agent.c | 8 +++--- > > > drivers/infiniband/core/agent.h | 4 +-- > > > drivers/infiniband/core/cache.c | 8 +++--- > > > drivers/infiniband/core/verbs.c | 9 ++++--- > > > drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++--- > > > drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++--- > > > drivers/infiniband/hw/cxgb4/provider.c | 5 ++-- > > > drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +-- > > > drivers/infiniband/hw/ehca/ehca_sqp.c | 4 +-- > > > drivers/infiniband/hw/ipath/ipath_mad.c | 8 +++--- > > > drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++--- > > > drivers/infiniband/hw/mlx4/mad.c | 21 ++++++++------- > > > drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 +++--- > > > drivers/infiniband/hw/mlx5/mad.c | 8 +++--- > > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +++--- > > > drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +-- > > > drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +-- > > > drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++--- > > > drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++---- > > > drivers/infiniband/hw/nes/nes_verbs.c | 4 +-- > > > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++--- > > > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++--- > > > drivers/infiniband/hw/qib/qib_mad.c | 10 +++---- > > > drivers/infiniband/hw/qib/qib_verbs.h | 4 +-- > > > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- > > > include/linux/mlx5/driver.h | 2 +- > > > include/rdma/ib_addr.h | 6 ++--- > > > include/rdma/ib_cache.h | 8 +++--- > > > include/rdma/ib_verbs.h | 39 ++++++++++++++------------- > > > 30 files changed, 116 insertions(+), 112 deletions(-) > > > > > > -- > > > 1.8.2 > > > > > > -- > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > GPG KeyID: 0E572FDD > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20150529151735.GA5372-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <20150529151735.GA5372-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> @ 2015-05-29 15:32 ` ira.weiny [not found] ` <20150529153231.GA10432-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> 2015-05-29 15:47 ` Doug Ledford 1 sibling, 1 reply; 15+ messages in thread From: ira.weiny @ 2015-05-29 15:32 UTC (permalink / raw) To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA > > > > Double check that they stand on their own. If they do, I'll review them > > separately. > > They do stand on their own and they are improvements even without the OPA code. After responding to this email I found a 0-day build email which shows a build warnings on this patch building ehca on PPC: IB/core: Add const to device process_mad I'm not sure why but sometimes my 0-day build results are delayed for quite some time? I'm guessing the servers prioritize kernel.org over github accounts??? Or I'm just doing something wrong... :-/ Sorry, Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20150529153231.GA10432-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <20150529153231.GA10432-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> @ 2015-05-29 15:48 ` Doug Ledford [not found] ` <1432914533.114391.88.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Doug Ledford @ 2015-05-29 15:48 UTC (permalink / raw) To: ira.weiny; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 927 bytes --] On Fri, 2015-05-29 at 11:32 -0400, ira.weiny wrote: > > > > > > Double check that they stand on their own. If they do, I'll review them > > > separately. > > > > They do stand on their own and they are improvements even without the OPA code. > > After responding to this email I found a 0-day build email which shows a > build warnings on this patch building ehca on PPC: > > IB/core: Add const to device process_mad > > I'm not sure why but sometimes my 0-day build results are delayed for quite > some time? I'm guessing the servers prioritize kernel.org over github > accounts??? Or I'm just doing something wrong... :-/ I've seen that too. I can't tell you what the issue is. However, I should take this to mean there is a both a v2 of this series, and a new OPA series on the way? -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: 0E572FDD [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <1432914533.114391.88.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <1432914533.114391.88.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2015-05-29 15:59 ` ira.weiny [not found] ` <20150529155937.GA17567-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: ira.weiny @ 2015-05-29 15:59 UTC (permalink / raw) To: Doug Ledford; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA > > However, I should take this to mean there is a both a v2 of this series, > and a new OPA series on the way? > Yes to both series. Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20150529155937.GA17567-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <20150529155937.GA17567-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> @ 2015-05-29 16:23 ` Doug Ledford 0 siblings, 0 replies; 15+ messages in thread From: Doug Ledford @ 2015-05-29 16:23 UTC (permalink / raw) To: ira.weiny; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 422 bytes --] On Fri, 2015-05-29 at 11:59 -0400, ira.weiny wrote: > > > > However, I should take this to mean there is a both a v2 of this series, > > and a new OPA series on the way? > > > > Yes to both series. Thanks. That allows me to clear out their existing entries in patchworks and wait for the new ones. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: 0E572FDD [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <20150529151735.GA5372-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> 2015-05-29 15:32 ` ira.weiny @ 2015-05-29 15:47 ` Doug Ledford 1 sibling, 0 replies; 15+ messages in thread From: Doug Ledford @ 2015-05-29 15:47 UTC (permalink / raw) To: ira.weiny; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 5295 bytes --] On Fri, 2015-05-29 at 11:17 -0400, ira.weiny wrote: > On Fri, May 29, 2015 at 08:54:59AM -0400, Doug Ledford wrote: > > On Fri, 2015-05-29 at 00:13 -0400, ira.weiny wrote: > > > On Thu, May 21, 2015 at 04:40:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > > > > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > > > > > Doug, Jason, > > > > > > Were there any issues with these clean ups? > > > > I haven't gotten to them yet. Your 14 patch OPA addition and this were > > on my queue for getting to relatively soonish. I *thought* this touched > > stuff that your 14 patch set also touched and so thought it needed to be > > on top of it, so that's part of the reason why I hadn't even looked at > > it yet (these emails are part of the "still new and unread" emails in my > > Inbox that seem to never get to 0 ;-). > > I understand. > > > > > > I think they stand on their own but I can add them to the OPA series if you > > > prefer. > > > > Double check that they stand on their own. If they do, I'll review them > > separately. > > They do stand on their own and they are improvements even without the OPA code. > > They became precursors to the next OPA series because I am changing some core > functions. In order to declare parameters of those core functions const the > entire call chain required updating. Rather than mix that call chain clean up > with the new OPA code I felt it would be easier to review these as separate > clean up patches. > > If this is an unorthodox procedure, is there a better way to handle something > like this? No, you did it fine. However, if this is to be a precursor to your next OPA patchset, then it is helpful to mention that in the cover letter (helps me make sure I do things in the right order). > As more and more clean up becomes necessary in the core I don't want the OPA > changes to become a huge patch series which is unwieldy to review and mostly > cleanup. (If you count Michaels changes the "clean up" to the core which OPA > now relies on count for more patches then the actual OPA changes.) I'm trying > to reduce the review workload by making clear which patches are clean up vs > actual OPA code. Yep, makes perfect sense. > Apologies, > Ira > > > > > > Ira > > > > > > > > > > > In order to support some of Jason's comments to add const to the functions I am > > > > adding for OPA the following patches clean up the call trees of the currently > > > > defined functions. > > > > > > > > They stand on their own as clean up patches. Therefore, I am submitting them > > > > separately from the OPA patches. > > > > > > > > Ira Weiny (3): > > > > IB/core: Add const to RDMA helpers > > > > IB/core: Add const to device process_mad > > > > IB/core: Add const to agent_send_response > > > > > > > > drivers/infiniband/core/addr.c | 4 +-- > > > > drivers/infiniband/core/agent.c | 8 +++--- > > > > drivers/infiniband/core/agent.h | 4 +-- > > > > drivers/infiniband/core/cache.c | 8 +++--- > > > > drivers/infiniband/core/verbs.c | 9 ++++--- > > > > drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++--- > > > > drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++--- > > > > drivers/infiniband/hw/cxgb4/provider.c | 5 ++-- > > > > drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +-- > > > > drivers/infiniband/hw/ehca/ehca_sqp.c | 4 +-- > > > > drivers/infiniband/hw/ipath/ipath_mad.c | 8 +++--- > > > > drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++--- > > > > drivers/infiniband/hw/mlx4/mad.c | 21 ++++++++------- > > > > drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 +++--- > > > > drivers/infiniband/hw/mlx5/mad.c | 8 +++--- > > > > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +++--- > > > > drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +-- > > > > drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +-- > > > > drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++--- > > > > drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++---- > > > > drivers/infiniband/hw/nes/nes_verbs.c | 4 +-- > > > > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++--- > > > > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++--- > > > > drivers/infiniband/hw/qib/qib_mad.c | 10 +++---- > > > > drivers/infiniband/hw/qib/qib_verbs.h | 4 +-- > > > > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- > > > > include/linux/mlx5/driver.h | 2 +- > > > > include/rdma/ib_addr.h | 6 ++--- > > > > include/rdma/ib_cache.h | 8 +++--- > > > > include/rdma/ib_verbs.h | 39 ++++++++++++++------------- > > > > 30 files changed, 116 insertions(+), 112 deletions(-) > > > > > > > > -- > > > > 1.8.2 > > > > > > > > > > -- > > Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > GPG KeyID: 0E572FDD > > > > -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: 0E572FDD [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] Add const to various core functions
@ 2015-05-31 21:15 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1433106931-5215-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 15+ messages in thread
From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2015-05-31 21:15 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Ira Weiny
From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
In order to support some of Jason's comments to add const to the functions I am
adding for OPA the following patches clean up the call trees of the currently
defined functions.
They stand on their own as clean up patches. Therefore, I am submitting them
separately from the OPA patches.
---
Changes from V1:
Clean up 0-day build
Clean up commit messages
Ira Weiny (3):
IB/core cleanup: Add const to RDMA helpers
IB/core cleanup: Add const on args - device->process_mad
IB/core cleanup: Add const to args - agent_send_response
drivers/infiniband/core/addr.c | 4 +-
drivers/infiniband/core/agent.c | 8 ++--
drivers/infiniband/core/agent.h | 4 +-
drivers/infiniband/core/cache.c | 8 ++--
drivers/infiniband/core/verbs.c | 9 +++--
drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++--
drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++--
drivers/infiniband/hw/cxgb4/provider.c | 5 ++-
drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +-
drivers/infiniband/hw/ehca/ehca_sqp.c | 14 ++++----
drivers/infiniband/hw/ipath/ipath_mad.c | 8 ++--
drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++--
drivers/infiniband/hw/mlx4/mad.c | 21 +++++++------
drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 ++--
drivers/infiniband/hw/mlx5/mad.c | 8 ++--
drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 ++--
drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +-
drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +-
drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++--
drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++---
drivers/infiniband/hw/nes/nes_verbs.c | 4 +-
drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++--
drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++--
drivers/infiniband/hw/qib/qib_mad.c | 10 +++---
drivers/infiniband/hw/qib/qib_verbs.h | 4 +-
drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +-
include/linux/mlx5/driver.h | 2 +-
include/rdma/ib_addr.h | 6 ++--
include/rdma/ib_cache.h | 8 ++--
include/rdma/ib_verbs.h | 39 +++++++++++++------------
30 files changed, 121 insertions(+), 117 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 15+ messages in thread[parent not found: <1433106931-5215-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <1433106931-5215-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2015-06-01 13:37 ` Hal Rosenstock 2015-06-01 17:32 ` Jason Gunthorpe 1 sibling, 0 replies; 15+ messages in thread From: Hal Rosenstock @ 2015-06-01 13:37 UTC (permalink / raw) To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA On 5/31/2015 5:15 PM, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > In order to support some of Jason's comments to add const to the functions I am > adding for OPA the following patches clean up the call trees of the currently > defined functions. > > They stand on their own as clean up patches. Therefore, I am submitting them > separately from the OPA patches. > > --- > Changes from V1: > Clean up 0-day build > Clean up commit messages > > Ira Weiny (3): > IB/core cleanup: Add const to RDMA helpers > IB/core cleanup: Add const on args - device->process_mad > IB/core cleanup: Add const to args - agent_send_response > > drivers/infiniband/core/addr.c | 4 +- > drivers/infiniband/core/agent.c | 8 ++-- > drivers/infiniband/core/agent.h | 4 +- > drivers/infiniband/core/cache.c | 8 ++-- > drivers/infiniband/core/verbs.c | 9 +++-- > drivers/infiniband/hw/amso1100/c2_provider.c | 6 ++-- > drivers/infiniband/hw/cxgb3/iwch_provider.c | 6 ++-- > drivers/infiniband/hw/cxgb4/provider.c | 5 ++- > drivers/infiniband/hw/ehca/ehca_iverbs.h | 4 +- > drivers/infiniband/hw/ehca/ehca_sqp.c | 14 ++++---- > drivers/infiniband/hw/ipath/ipath_mad.c | 8 ++-- > drivers/infiniband/hw/ipath/ipath_verbs.h | 6 ++-- > drivers/infiniband/hw/mlx4/mad.c | 21 +++++++------ > drivers/infiniband/hw/mlx4/mlx4_ib.h | 8 ++-- > drivers/infiniband/hw/mlx5/mad.c | 8 ++-- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 ++-- > drivers/infiniband/hw/mthca/mthca_cmd.c | 4 +- > drivers/infiniband/hw/mthca/mthca_cmd.h | 4 +- > drivers/infiniband/hw/mthca/mthca_dev.h | 6 ++-- > drivers/infiniband/hw/mthca/mthca_mad.c | 10 +++--- > drivers/infiniband/hw/nes/nes_verbs.c | 4 +- > drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ++-- > drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 6 ++-- > drivers/infiniband/hw/qib/qib_mad.c | 10 +++--- > drivers/infiniband/hw/qib/qib_verbs.h | 4 +- > drivers/net/ethernet/mellanox/mlx5/core/mad.c | 2 +- > include/linux/mlx5/driver.h | 2 +- > include/rdma/ib_addr.h | 6 ++-- > include/rdma/ib_cache.h | 8 ++-- > include/rdma/ib_verbs.h | 39 +++++++++++++------------ > 30 files changed, 121 insertions(+), 117 deletions(-) Reviewed-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/3] Add const to various core functions [not found] ` <1433106931-5215-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2015-06-01 13:37 ` Hal Rosenstock @ 2015-06-01 17:32 ` Jason Gunthorpe 1 sibling, 0 replies; 15+ messages in thread From: Jason Gunthorpe @ 2015-06-01 17:32 UTC (permalink / raw) To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA, linux-rdma-u79uwXL29TY76Z2rM5mHXA On Sun, May 31, 2015 at 05:15:28PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: > From: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > In order to support some of Jason's comments to add const to the functions I am > adding for OPA the following patches clean up the call trees of the currently > defined functions. This is longer than I imagined, but looks good. Reviewed-By: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-06-01 17:32 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-21 20:40 [PATCH 0/3] Add const to various core functions ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1432240824-3277-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-05-21 20:40 ` [PATCH 1/3] IB/core: Add const to RDMA helpers ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-05-21 20:40 ` [PATCH 2/3] IB/core: Add const to device process_mad ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-05-21 20:40 ` [PATCH 3/3] IB/core: Add const to agent_send_response ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2015-05-29 4:13 ` [PATCH 0/3] Add const to various core functions ira.weiny
[not found] ` <20150529041313.GA1603-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-29 12:54 ` Doug Ledford
[not found] ` <1432904099.114391.61.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-29 15:17 ` ira.weiny
[not found] ` <20150529151735.GA5372-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-29 15:32 ` ira.weiny
[not found] ` <20150529153231.GA10432-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-29 15:48 ` Doug Ledford
[not found] ` <1432914533.114391.88.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-29 15:59 ` ira.weiny
[not found] ` <20150529155937.GA17567-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2015-05-29 16:23 ` Doug Ledford
2015-05-29 15:47 ` Doug Ledford
-- strict thread matches above, loose matches on Subject: below --
2015-05-31 21:15 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1433106931-5215-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-06-01 13:37 ` Hal Rosenstock
2015-06-01 17:32 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox