Re: [PATCH for-next V1 10/11] IB/mlx4: Add timestamp_mask and hca_core_clock to query_device

Doug Ledford
2015-05-29T16:41:24Z

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

On Thu, 2015-05-21 at 17:56 +0300, Or Gerlitz wrote:
> From: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> mlx4 needs to report the number of supported timestamp
> bits (mask) and the hca_core_clock frequency.
>
> Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx4/main.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index ef211c8..a5a90c4 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -233,6 +233,8 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> props->max_total_mcast_qp_attach = props->max_mcast_qp_attach *
> props->max_mcast_grp;
> props->max_map_per_fmr = dev->dev->caps.max_fmr_maps;
> + props->hca_core_clock = dev->dev->caps.hca_core_clock;
> + props->timestamp_mask = 0xFFFFFFFFFFFFULL;
>
> out:
> kfree(in_mad);

Or, please squash 8, 9, and 10 to a single patch. They all are "add
support for timestamping to mlx4" but without squashing them together,
the support they add is broken/partial.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]