Re: LINUX RDMA MAILING LIST MONITOR ALERT - RE: [PATCH for-next V5 00/12] Move RoCE GID management to IB/Core

[Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 3202 bytes --]

On Wed, 2015-06-10 at 23:17 +0000, Diego Crupnicoff wrote:
> Here Sean reacts to our RoCEv2 patches (same thread as the one I sent before with Jason's feedback).
> Sean is not even making technical statements to dismiss our patches. He has been rejecting all our previous revs of this set with loose FUD comments. In this case he chose to count the lines of code. 

Sean made a observation: the code was claimed to be a cleanup while it
is significantly larger in size than the code it is cleaning up.  A
cleanup usually doesn't increase size count significantly.  This is
especially true when the cleanup also included deduplication.  It's a
valid assessment.  As I pointed out in the thread, the problem here is
as much as anything else calling the patch set a cleanup.  It is more
than that.  It replaces two partial implementations of RoCE GID
management with one more complete, standardized one.  Once you get past
the improper use of the term cleanup for this patchset, you can review
it more productively.

Sean, while the code is more than a cleanup, it does not include RoCEv2
code and they did do as Jason requested in removing it.  You're under no
obligation to review the code, but your stated reason for ignoring it is
only partially correct.

This isn't the first email to have a less than constructive tone.  I
would appreciate it if people took a moment to breath before hitting
send and remember that we built up quite a backlog of work that needs to
be reviewed and everyone may be a bit frustrated as they try to get
their own projects approved, so please be considerate and constructive.

> 
> > -----Original Message-----
> > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hefty, Sean
> > Sent: Wednesday, June 10, 2015 12:10 PM
> > To: Or Gerlitz; Doug Ledford; Jason Gunthorpe
> > Cc: Matan Barak; Moni Shoua; Somnath Kotur; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: RE: [PATCH for-next V5 00/12] Move RoCE GID management to
> > IB/Core
> > 
> > > Sean, this change is needed b/c two drivers have (mlx4 and ocrda) and
> > > more two to come soon (mlx5 and soft-Roce) would have the very same
> > > logic of constructing the port GID table according to netdev events
> > > and such, no point in repeating this logic/code over and over.
> > >
> > > Matan explained why we don't have 2 x Y deletions and 1 x Y insertions.
> > 
> > It more than doubles the amount of code.  That's not a cleanup.  It introduces
> > a bunch of new functionality.  Jason has asked repeatedly to remove the
> > RoCEv2 code, and that has been ignored repeatedly.  As far as I'm concerned,
> > this patch is not worth my time, and I will no longer even bother following
> > this series.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the
> > body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at
> > http://vger.kernel.org/majordomo-info.html


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]