From: "Luis R. Rodriguez" <mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
To: bp-l3A5Bk7waGM@public.gmane.org,
andy-JCKMKWeByS3xr+NhZqW+5SMd26UNKDXL@public.gmane.org,
mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>
Subject: [PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()
Date: Wed, 24 Jun 2015 10:23:19 -0700 [thread overview]
Message-ID: <1435166600-11956-2-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1435166600-11956-1-git-send-email-mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
From: "Luis R. Rodriguez" <mcgrof-IBi9RG/b67k@public.gmane.org>
WARN() may confuse users, fix that. ipath_init_one() is part the
device's probe so this would only be triggered if a corresponding
device was found.
Signed-off-by: Luis R. Rodriguez <mcgrof-IBi9RG/b67k@public.gmane.org>
---
drivers/infiniband/hw/ipath/ipath_driver.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c b/drivers/infiniband/hw/ipath/ipath_driver.c
index 2d7e503..871dbe5 100644
--- a/drivers/infiniband/hw/ipath/ipath_driver.c
+++ b/drivers/infiniband/hw/ipath/ipath_driver.c
@@ -31,6 +31,8 @@
* SOFTWARE.
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/sched.h>
#include <linux/spinlock.h>
#include <linux/idr.h>
@@ -399,8 +401,8 @@ static int ipath_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
u32 bar0 = 0, bar1 = 0;
#ifdef CONFIG_X86_64
- if (WARN(pat_enabled(),
- "ipath needs PAT disabled, boot with nopat kernel parameter\n")) {
+ if (pat_enabled()) {
+ pr_warn("ipath needs PAT disabled, boot with nopat kernel parameter\n");
ret = -ENODEV;
goto bail;
}
--
2.3.2.209.gd67f9d5.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-06-24 17:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 17:23 [PATCH v2 0/2] x86/mm/pat: modify nopat requirement warning Luis R. Rodriguez
[not found] ` <1435166600-11956-1-git-send-email-mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org>
2015-06-24 17:23 ` Luis R. Rodriguez [this message]
2015-06-25 6:49 ` [PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn() Ingo Molnar
[not found] ` <20150625064922.GA5339-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-25 17:15 ` Luis R. Rodriguez
2015-06-26 8:44 ` Ingo Molnar
2015-06-24 17:23 ` [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and " Luis R. Rodriguez
2015-06-25 6:51 ` Ingo Molnar
[not found] ` <20150625065147.GB5339-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-06-25 17:38 ` Luis R. Rodriguez
[not found] ` <20150625173847.GH3005-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2015-06-26 8:45 ` Ingo Molnar
2015-06-26 12:36 ` Andy Walls
2015-06-29 6:55 ` Ingo Molnar
[not found] ` <57337D5A-7486-4D01-8316-DFAF4CAF3DA7@md.metrocast.net>
2015-07-07 0:44 ` Luis R. Rodriguez
2015-07-07 6:53 ` Luis R. Rodriguez
[not found] ` <CAB=NE6WzpSLREPkLt0k1_42V5DGKYQx3cqMnGeOFwv1-wkxVhg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-07 7:03 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435166600-11956-2-git-send-email-mcgrof@do-not-panic.com \
--to=mcgrof-3uybbjdb1yh774rrrx3eta@public.gmane.org \
--cc=andy-JCKMKWeByS3xr+NhZqW+5SMd26UNKDXL@public.gmane.org \
--cc=bp-l3A5Bk7waGM@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mcgrof-IBi9RG/b67k@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox