Re: [PATCH 1/4] IB/isert: properly type the login buffer

Christoph Hellwig
2016-02-17T10:29:52Z

On Tue, Feb 16, 2016 at 06:40:58AM +0200, Leon Romanovsky wrote:
> > - isert_conn->login_buf = kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN +
> > - ISER_RX_LOGIN_SIZE, GFP_KERNEL);
> > - if (!isert_conn->login_buf) {
> > - isert_err("Unable to allocate isert_conn->login_buf\n");
> > + isert_conn->login_req_buf =
> > + kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN, GFP_KERNEL);
> > + if (!isert_conn->login_req_buf) {
> > + isert_err("Unable to allocate isert_conn->login_req_buf\n");
>
> Please don't print additional allocation failure messages after
> kzalloc/kmalloc.

I don't personally like that style, but it's prelevant in this driver,
and without an explicit request from the maintainer (Sagi) I'm going
to stick to the drivers style.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html