Re: [PATCH 1/4] IB/isert: properly type the login buffer

Leon Romanovsky
2016-02-16T04:40:58Z

On Mon, Feb 15, 2016 at 09:10:57PM +0100, Christoph Hellwig wrote:
>
> - isert_conn->login_buf = kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN +
> - ISER_RX_LOGIN_SIZE, GFP_KERNEL);
> - if (!isert_conn->login_buf) {
> - isert_err("Unable to allocate isert_conn->login_buf\n");
> + isert_conn->login_req_buf =
> + kzalloc(ISCSI_DEF_MAX_RECV_SEG_LEN, GFP_KERNEL);
> + if (!isert_conn->login_req_buf) {
> + isert_err("Unable to allocate isert_conn->login_req_buf\n");

Please don't print additional allocation failure messages after
kzalloc/kmalloc.

It is relevant to all places in this patch.

> return -ENOMEM;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html