From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: target-devel@vger.kernel.org, linux-rdma@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 09/12] iser-target: Convert to new CQ API
Date: Thu, 25 Feb 2016 22:03:52 -0800 [thread overview]
Message-ID: <1456466632.32369.56.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <1456334649-21437-10-git-send-email-sagig@mellanox.com>
On Wed, 2016-02-24 at 19:24 +0200, Sagi Grimberg wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> Use the workqueue based CQ type similar to what isert was using previously,
> and properly split up the completion handlers.
>
> Note that this also takes special care to handle the magic login WRs
> separately, and also renames the submission functions so that it's clear
> that they are only to be used for the login buffers.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> [sagig: added iscsi conn reinstatement in non-flush
> error completions and added error completion type print]
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> drivers/infiniband/ulp/isert/ib_isert.c | 405 +++++++++++++-------------------
> drivers/infiniband/ulp/isert/ib_isert.h | 22 +-
> 2 files changed, 184 insertions(+), 243 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
> index ac3e80c55965..76ff3388890d 100644
> --- a/drivers/infiniband/ulp/isert/ib_isert.c
> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
<SNIP>
> @@ -3303,14 +3224,26 @@ isert_wait4cmds(struct iscsi_conn *conn)
> }
>
> static void
> +isert_beacon_done(struct ib_cq *cq, struct ib_wc *wc)
> +{
> + struct isert_conn *isert_conn = wc->qp->qp_context;
> +
> + isert_print_wc(wc);
> +
> + isert_info("conn %p completing wait_comp_err\n", isert_conn);
> + complete(&isert_conn->wait_comp_err);
> +}
> +
drivers/infiniband/ulp/isert/ib_isert.c: In function ‘isert_beacon_done’:
drivers/infiniband/ulp/isert/ib_isert.c:3221:2: error: too few arguments to function ‘isert_print_wc’
drivers/infiniband/ulp/isert/ib_isert.c:1538:1: note: declared here
make[4]: *** [drivers/infiniband/ulp/isert/ib_isert.o] Error 1
make[3]: *** [drivers/infiniband/ulp/isert] Error 2
Fixing up the build breakage here.
next prev parent reply other threads:[~2016-02-26 6:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 17:23 [PATCH 00/12] iser target patches for 4.6 Sagi Grimberg
2016-02-24 17:23 ` [PATCH 01/12] iser-target: Fix identification of login rx descriptor type Sagi Grimberg
2016-02-24 17:24 ` [PATCH 03/12] iser-target: Separate flows for np listeners and connections cma events Sagi Grimberg
2016-02-24 17:24 ` [PATCH 04/12] iser-target: Rework connection termination Sagi Grimberg
[not found] ` <1456334649-21437-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 17:23 ` [PATCH 02/12] iser-target: Add new state ISER_CONN_BOUND to isert_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 05/12] iser-target: Remove redundant wait in release_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 06/12] iser-target: Remove impossible condition from isert_wait_conn Sagi Grimberg
2016-02-24 17:24 ` [PATCH 08/12] iser-target: Split and properly type the login buffer Sagi Grimberg
2016-02-24 17:24 ` [PATCH 09/12] iser-target: Convert to new CQ API Sagi Grimberg
2016-02-24 22:01 ` kbuild test robot
2016-02-25 8:53 ` Sagi Grimberg
2016-02-26 6:03 ` Nicholas A. Bellinger [this message]
2016-02-24 17:26 ` [PATCH 00/12] iser target patches for 4.6 Sagi Grimberg
2016-02-26 5:59 ` Nicholas A. Bellinger
2016-02-24 17:24 ` [PATCH 07/12] iser-target: Remove ISER_RECV_DATA_SEG_LEN Sagi Grimberg
2016-02-24 17:24 ` [PATCH 10/12] iser-target: Kill struct isert_rdma_wr Sagi Grimberg
2016-02-24 17:24 ` [PATCH 11/12] iser-target: Kill the ->isert_cmd back pointer in struct iser_tx_desc Sagi Grimberg
2016-02-24 17:24 ` [PATCH 12/12] iser-target: Use ib_drain_qp Sagi Grimberg
[not found] ` <1456334649-21437-13-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-24 17:28 ` Sagi Grimberg
2016-02-24 18:08 ` kbuild test robot
[not found] ` <201602250232.0MaJNmx5%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-02-25 8:49 ` Sagi Grimberg
2016-02-27 23:36 ` Nicholas A. Bellinger
[not found] ` <1456616190.1750.54.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2016-02-28 10:54 ` Sagi Grimberg
2016-03-23 7:48 ` Christoph Hellwig
2016-03-31 4:24 ` Nicholas A. Bellinger
2016-04-03 13:15 ` sagig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456466632.32369.56.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=hch@lst.de \
--cc=linux-rdma@vger.kernel.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox