Re: [PATCH rdma-next V2 03/10] IB/core: Add subnet prefix to port info

Eli Cohen
2016-03-08T18:04:28Z

On Tue, Mar 08, 2016 at 10:57:52AM -0700, Jason Gunthorpe wrote:
>
> Looks reasonable
>
> Are you going to still send the mlx4/5 changes to avoid the other
> callback?

I don't think it is necessary since the hardware driver will do the
same thing to obtain the subnet prefix so I don't think it has any
siginficant benefit.
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
>

Thanks

> > +++ b/include/rdma/ib_verbs.h
> > @@ -509,6 +509,7 @@ struct ib_port_attr {
> > u8 active_width;
> > u8 active_speed;
> > u8 phys_state;
> > + u64 subnet_prefix;
> > };
>
> This turned out to be aligned then?
>

Actually I missed this comment of yours. I will fix that as well.