public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Noa Osherovich <noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: [PATCH rdma-rc 05/10] IB/mlx5: Fix returned values of query QP
Date: Sat,  4 Jun 2016 15:15:32 +0300	[thread overview]
Message-ID: <1465042537-26129-6-git-send-email-leon@kernel.org> (raw)
In-Reply-To: <1465042537-26129-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

From: Noa Osherovich <noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Some variables were not initialized properly: max_recv_wr,
max_recv_sge, max_send_wr, qp_context and max_inline_data.

Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB...')
Signed-off-by: Noa Osherovich <noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/infiniband/hw/mlx5/qp.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 5041176..43c1441 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -235,6 +235,8 @@ static int set_rq_size(struct mlx5_ib_dev *dev, struct ib_qp_cap *cap,
 		qp->rq.max_gs = 0;
 		qp->rq.wqe_cnt = 0;
 		qp->rq.wqe_shift = 0;
+		cap->max_recv_wr = 0;
+		cap->max_recv_sge = 0;
 	} else {
 		if (ucmd) {
 			qp->rq.wqe_cnt = ucmd->rq_wqe_count;
@@ -4079,17 +4081,19 @@ int mlx5_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
 	qp_attr->cap.max_recv_sge    = qp->rq.max_gs;
 
 	if (!ibqp->uobject) {
-		qp_attr->cap.max_send_wr  = qp->sq.wqe_cnt;
+		qp_attr->cap.max_send_wr  = qp->sq.max_post;
 		qp_attr->cap.max_send_sge = qp->sq.max_gs;
+		qp_init_attr->qp_context = ibqp->qp_context;
 	} else {
 		qp_attr->cap.max_send_wr  = 0;
 		qp_attr->cap.max_send_sge = 0;
 	}
 
-	/* We don't support inline sends for kernel QPs (yet), and we
-	 * don't know what userspace's value should be.
-	 */
-	qp_attr->cap.max_inline_data = 0;
+	qp_init_attr->qp_type = ibqp->qp_type;
+	qp_init_attr->recv_cq = ibqp->recv_cq;
+	qp_init_attr->send_cq = ibqp->send_cq;
+	qp_init_attr->srq = ibqp->srq;
+	qp_attr->cap.max_inline_data = qp->max_inline_data;
 
 	qp_init_attr->cap	     = qp_attr->cap;
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-06-04 12:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 12:15 [PATCH rdma-rc 00/10] IB mlx5 fixes for 4.7 Leon Romanovsky
     [not found] ` <1465042537-26129-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-06-04 12:15   ` [PATCH rdma-rc 01/10] IB/mlx5: Set flow steering capability bit Leon Romanovsky
2016-06-04 12:15   ` [PATCH rdma-rc 02/10] IB/mlx5: Return PORT_ERR in Active to Initializing tranisition Leon Romanovsky
2016-06-04 12:15   ` [PATCH rdma-rc 03/10] IB/mlx5: Fix FW version diaplay in sysfs Leon Romanovsky
2016-06-04 12:15   ` [PATCH rdma-rc 04/10] IB/mlx5: Limit query HCA clock Leon Romanovsky
2016-06-04 12:15   ` Leon Romanovsky [this message]
     [not found]     ` <1465042537-26129-6-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-06-06 11:23       ` [PATCH rdma-rc 05/10] IB/mlx5: Fix returned values of query QP Sagi Grimberg
2016-06-04 12:15   ` [PATCH rdma-rc 06/10] IB/mlx5: Check BlueFlame HCA support Leon Romanovsky
     [not found]     ` <1465042537-26129-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-06-06 11:23       ` Sagi Grimberg
2016-06-04 12:15   ` [PATCH rdma-rc 07/10] IB/mlx5: Fix entries checks in mlx5_ib_create_cq Leon Romanovsky
     [not found]     ` <1465042537-26129-8-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-06-06 11:24       ` Sagi Grimberg
2016-06-04 12:15   ` [PATCH rdma-rc 08/10] IB/mlx5: Fix entries check in mlx5_ib_resize_cq Leon Romanovsky
2016-06-04 12:15   ` [PATCH rdma-rc 09/10] IB/mlx5: Fix pkey_index length in the QP path record Leon Romanovsky
2016-06-04 12:15   ` [PATCH rdma-rc 10/10] IB/mlx5: Fix alternate path code Leon Romanovsky
2016-06-07  8:18   ` [PATCH rdma-rc 00/10] IB mlx5 fixes for 4.7 Leon Romanovsky
     [not found]     ` <20160607081845.GF3663-2ukJVAZIZ/Y@public.gmane.org>
2016-06-07 14:01       ` Doug Ledford
     [not found]         ` <edfddbd4-7789-18d9-c503-273a8494de21-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-07 16:32           ` Leon Romanovsky
     [not found]             ` <20160607163224.GI3663-2ukJVAZIZ/Y@public.gmane.org>
2016-06-07 19:56               ` Doug Ledford
2016-06-07 14:24       ` Laurence Oberman
     [not found]         ` <1915944393.40937640.1465309481061.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-09  1:49           ` Laurence Oberman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465042537-26129-6-git-send-email-leon@kernel.org \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox