Re: [PATCH 12/13] IB/core: Export a common fw_ver sysfs entry

Jason Gunthorpe
2016-06-09T22:40:38Z

On Thu, Jun 09, 2016 at 05:54:07PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
>
> +static ssize_t show_fw_ver(struct device *device, struct device_attribute *attr,
> + char *buf)
> +{
> + char tmp[ETHTOOL_FWVERS_LEN];
> + struct ib_device *dev = container_of(device, struct ib_device, dev);
> +
> + ib_get_device_fw_str(dev, tmp, sizeof(tmp));
> +
> + return scnprintf(buf, PAGE_SIZE, "%s\n", tmp);

No need to use the stack:

ib_get_device_fw_str(dev, buf, PAGE_SIZE);
strlcat(buf, "", PAGE_SIZE);
return strlen(buf);

> &dev_attr_node_guid,
> - &dev_attr_node_desc
> + &dev_attr_node_desc,
> + &dev_attr_fw_ver

Should be
+ &dev_attr_fw_ver,

Note trailing comma. Avoids git churn like the above on append.

Jason