From: Arnd Bergmann <arnd@arndb.de>
To: Leon Romanovsky <leon@kernel.org>
Cc: netdev@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Moni Shoua <monis@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Kamal Heib <kamalh@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] infiniband: rxe: fix 32-bit build warnings
Date: Mon, 13 Jun 2016 14:54:55 +0200 [thread overview]
Message-ID: <1465822509-4167617-3-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1465822509-4167617-1-git-send-email-arnd@arndb.de>
The new rxe infinband driver passes around pointers that have been
converted to 64-bit integers. This is valid, but causes compile-time
warnings on all 32-bit architectures:
infiniband/hw/rxe/rxe_dma.c: In function 'rxe_dma_map_single':
infiniband/hw/rxe/rxe_dma.c:49:9: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
return (u64)cpu_addr;
^
infiniband/hw/rxe/rxe_dma.c: In function 'rxe_dma_map_page':
infiniband/hw/rxe/rxe_dma.c:73:9: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
infiniband/hw/rxe/rxe_dma.c: In function 'rxe_map_sg':
infiniband/hw/rxe/rxe_dma.c:99:10: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
infiniband/hw/rxe/rxe_dma.c: In function 'rxe_dma_alloc_coherent':
infiniband/hw/rxe/rxe_dma.c:143:17: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
This changes the cast to use 'uintptr_t', which can always be
cast to and from pointer, and can be assigned to and from 64-bit
integers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/infiniband/hw/rxe/rxe_dma.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/rxe/rxe_dma.c b/drivers/infiniband/hw/rxe/rxe_dma.c
index f080bc5bda43..7634c1a81b2b 100644
--- a/drivers/infiniband/hw/rxe/rxe_dma.c
+++ b/drivers/infiniband/hw/rxe/rxe_dma.c
@@ -46,7 +46,7 @@ static u64 rxe_dma_map_single(struct ib_device *dev,
enum dma_data_direction direction)
{
WARN_ON(!valid_dma_direction(direction));
- return (u64)cpu_addr;
+ return (uintptr_t)cpu_addr;
}
static void rxe_dma_unmap_single(struct ib_device *dev,
@@ -70,7 +70,7 @@ static u64 rxe_dma_map_page(struct ib_device *dev,
goto done;
}
- addr = (u64)page_address(page);
+ addr = (uintptr_t)page_address(page);
if (addr)
addr += offset;
@@ -96,7 +96,7 @@ static int rxe_map_sg(struct ib_device *dev, struct scatterlist *sgl,
WARN_ON(!valid_dma_direction(direction));
for_each_sg(sgl, sg, nents, i) {
- addr = (u64)page_address(sg_page(sg));
+ addr = (uintptr_t)page_address(sg_page(sg));
if (!addr) {
ret = 0;
break;
@@ -140,7 +140,7 @@ static void *rxe_dma_alloc_coherent(struct ib_device *dev, size_t size,
addr = page_address(p);
if (dma_handle)
- *dma_handle = (u64)addr;
+ *dma_handle = (uintptr_t)addr;
return addr;
}
--
2.7.0
next prev parent reply other threads:[~2016-06-13 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 12:54 [PATCH 1/3] infiniband: rxe: avoid 64-bit division Arnd Bergmann
2016-06-13 12:54 ` [PATCH 2/3] infiniband: rxe: add UDP_TUNNEL dependency Arnd Bergmann
[not found] ` <1465822509-4167617-2-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-06-13 15:28 ` Moni Shoua
2016-06-13 12:54 ` Arnd Bergmann [this message]
[not found] ` <1465822509-4167617-3-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2016-06-13 15:29 ` [PATCH 3/3] infiniband: rxe: fix 32-bit build warnings Moni Shoua
2016-06-13 13:18 ` [PATCH 1/3] infiniband: rxe: avoid 64-bit division Leon Romanovsky
[not found] ` <20160613131840.GJ5408-2ukJVAZIZ/Y@public.gmane.org>
2016-06-13 15:27 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465822509-4167617-3-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dledford@redhat.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=kamalh@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox