From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH] nvmet/rdma: fix ptr_ret.cocci warnings
Date: Mon, 13 Jun 2016 23:57:50 -0700
Message-ID: <1465887470.5365.221.camel@haakon3.risingtidesystems.com>
References: <201606141338.n0GrvsGu%fengguang.wu@intel.com>
	 <20160614052541.GA19284@lkp-nex05>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <target-devel-owner@vger.kernel.org>
In-Reply-To: <20160614052541.GA19284@lkp-nex05>
Sender: target-devel-owner@vger.kernel.org
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
List-Id: linux-rdma@vger.kernel.org

On Tue, 2016-06-14 at 13:25 +0800, kbuild test robot wrote:
> drivers/nvme/target/rdma.c:1441:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  rdma.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> --- a/drivers/nvme/target/rdma.c
> +++ b/drivers/nvme/target/rdma.c
> @@ -1438,10 +1438,7 @@ static int nvmet_rdma_add_port(struct nv
>  	mutex_unlock(&nvmet_rdma_ports_mutex);
>  
>  	rdma_port = nvmet_rdma_listen_cmid(pb);
> -	if (IS_ERR(rdma_port))
> -		return PTR_ERR(rdma_port);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(rdma_port);
>  }
>  

Applied.  Thanks Fengguang!