From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: [PATCH 01/11] IB/core: Fix no default GIDs when netdevice reregisters
Date: Wed, 22 Jun 2016 17:27:22 +0300 [thread overview]
Message-ID: <1466605652-24798-2-git-send-email-leonro@mellanox.com> (raw)
In-Reply-To: <1466605652-24798-1-git-send-email-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
From: Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Currently, when the netdevice returned by get_netdev is unregistered,
we delete all GIDs (including the default GIDs) and reset their
attributes. Therefore, when we re-register it, no default GIDs
will be assigned (as their "default GID") attribute will be reset.
Fixing this by keeping "default GID" attribute.
Fixes: 03db3a2d81e6 ('IB/core: Add RoCE GID table management')
Signed-off-by: Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
drivers/infiniband/core/cache.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
index 0409667..1a2984c 100644
--- a/drivers/infiniband/core/cache.c
+++ b/drivers/infiniband/core/cache.c
@@ -411,7 +411,9 @@ int ib_cache_gid_del_all_netdev_gids(struct ib_device *ib_dev, u8 port,
for (ix = 0; ix < table->sz; ix++)
if (table->data_vec[ix].attr.ndev == ndev)
- if (!del_gid(ib_dev, port, table, ix, false))
+ if (!del_gid(ib_dev, port, table, ix,
+ !!(table->data_vec[ix].props &
+ GID_TABLE_ENTRY_DEFAULT)))
deleted = true;
write_unlock_irq(&table->rwlock);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-22 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 14:27 [PATCH rdma 00/11] IB core,mlx5,mlx4 fixes for 4.7-rc4 Leon Romanovsky
[not found] ` <1466605652-24798-1-git-send-email-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-22 14:27 ` Leon Romanovsky [this message]
2016-06-22 14:27 ` [PATCH 02/11] IB/core: Fix RoCE v1 multicast join logic issue Leon Romanovsky
2016-06-22 14:27 ` [PATCH 03/11] IB/core: Fix false search of the IB_SA_WELL_KNOWN_GUID Leon Romanovsky
2016-06-22 14:27 ` [PATCH 04/11] IB/uverbs: Initialize ib_qp_init_attr with zeros Leon Romanovsky
2016-06-22 14:27 ` [PATCH 05/11] IB/mlx5: Fix post send fence logic Leon Romanovsky
2016-06-22 14:27 ` [PATCH 06/11] IB/mlx5: Fix wrong naming of port_rcv_data counter Leon Romanovsky
2016-06-22 14:27 ` [PATCH 07/11] IB/mlx4: Fix the SQ size of an RC QP Leon Romanovsky
2016-06-22 14:27 ` [PATCH 08/11] IB/mlx4: Fix error flow when sending mads under SRIOV Leon Romanovsky
2016-06-22 14:27 ` [PATCH 09/11] IB/mlx4: Check that port number is valid in flow steering create flow Leon Romanovsky
2016-06-22 14:27 ` [PATCH 10/11] IB/mlx4: Fix memory leak if QP creation failed Leon Romanovsky
2016-06-22 14:27 ` [PATCH 11/11] IB/mlx4: Prevent cross page boundary allocation Leon Romanovsky
[not found] ` <1466605652-24798-12-git-send-email-leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-22 15:01 ` Dennis Dalessandro
[not found] ` <20160622150141.GA25806-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-06-22 16:00 ` Leon Romanovsky
2016-06-23 14:11 ` [PATCH rdma 00/11] IB core,mlx5,mlx4 fixes for 4.7-rc4 Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466605652-24798-2-git-send-email-leonro@mellanox.com \
--to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox