linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 10/13] IB/hfi1: Make iovec loop index easy to understand
Date: Thu, 28 Jul 2016 12:27:34 -0400	[thread overview]
Message-ID: <1469723257-27317-11-git-send-email-ira.weiny@intel.com> (raw)
In-Reply-To: <1469723257-27317-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

From: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/hfi1/user_sdma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/user_sdma.c b/drivers/infiniband/hw/hfi1/user_sdma.c
index 54640c31b6bb..586f07807b27 100644
--- a/drivers/infiniband/hw/hfi1/user_sdma.c
+++ b/drivers/infiniband/hw/hfi1/user_sdma.c
@@ -520,7 +520,7 @@ static u8 dlid_to_selector(u16 dlid)
 int hfi1_user_sdma_process_request(struct file *fp, struct iovec *iovec,
 				   unsigned long dim, unsigned long *count)
 {
-	int ret = 0, i = 0;
+	int ret = 0, i;
 	struct hfi1_filedata *fd = fp->private_data;
 	struct hfi1_ctxtdata *uctxt = fd->uctxt;
 	struct hfi1_user_sdma_pkt_q *pq = fd->pq;
@@ -657,7 +657,7 @@ int hfi1_user_sdma_process_request(struct file *fp, struct iovec *iovec,
 	idx++;
 
 	/* Save all the IO vector structures */
-	while (i < req->data_iovs) {
+	for (i = 0; i < req->data_iovs; i++) {
 		INIT_LIST_HEAD(&req->iovs[i].list);
 		memcpy(&req->iovs[i].iov, iovec + idx++, sizeof(struct iovec));
 		ret = pin_vector_pages(req, &req->iovs[i]);
@@ -665,7 +665,7 @@ int hfi1_user_sdma_process_request(struct file *fp, struct iovec *iovec,
 			req->status = ret;
 			goto free_req;
 		}
-		req->data_len += req->iovs[i++].iov.iov_len;
+		req->data_len += req->iovs[i].iov.iov_len;
 	}
 	SDMA_DBG(req, "total data length %u", req->data_len);
 
-- 
1.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-07-28 16:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-28 16:27 [PATCH 00/13] Code clean ups for 4.8 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
     [not found] ` <1469723257-27317-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-28 16:27   ` [PATCH 01/13] IB/hfi1: Fix minor format error ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 02/13] IB/hfi1: Remove unused uctxt->subpid and uctxt->pid ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 03/13] IB/hfi1: Remove unused function hfi1_mmu_rb_search ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 04/13] IB/hfi1: Add parameter names to function declarations ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 05/13] IB/hfi1: Add parameter names to callback declarations ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 06/13] IB/hfi1: Always expect ops functions ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 07/13] IB/hfi1: Consolidate __mmu_rb_remove and hfi1_mmu_rb_remove ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 08/13] IB/hfi1: Remove unused sub-context parameter ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 09/13] IB/hfi1: Use "false" not 0 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` ira.weiny-ral2JQCrhuEAvxtiuMwx3w [this message]
2016-07-28 16:27   ` [PATCH 11/13] IB/hfi1: Restructure hfi1_file_open ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 12/13] IB/hfi1: Remove unneeded empty check in hfi1_mmu_rb_unregister() ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-07-28 16:27   ` [PATCH 13/13] IB/hfi1: Rename TID mmu_rb_* functions ira.weiny-ral2JQCrhuEAvxtiuMwx3w
2016-08-03  2:52   ` [PATCH 00/13] Code clean ups for 4.8 Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469723257-27317-11-git-send-email-ira.weiny@intel.com \
    --to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).